Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update flipcard template #1752

Open
wants to merge 9 commits into
base: next
Choose a base branch
from
Open

fix: update flipcard template #1752

wants to merge 9 commits into from
+46 −19

Conversation

paulovareiro29
Copy link
Contributor

@paulovareiro29 paulovareiro29 commented Dec 23, 2024 •
edited
Loading

Description:

Closes #1518

This PR addresses:

  • Fixed issue with gradients on flipcard (noticed it when creating the template)
  • Implement flipcard template according to design

Definition of Reviewable:

  • Stories (features, a11y) are created/updated
  • relevant tickets are linked

@paulovareiro29 paulovareiro29 self-assigned this Dec 23, 2024
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 23, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 552da2c

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 23, 2024 •
edited
Loading

🚀 Storybook has been deployed for branch fix_flipcard-template-images-alt

@paulovareiro29 paulovareiro29 marked this pull request as draft January 6, 2025 09:52
@paulovareiro29 paulovareiro29 changed the title fix: image alt text on flipcard template fix: update flipcard template Jan 6, 2025
@paulovareiro29 paulovareiro29 marked this pull request as ready for review January 6, 2025 11:03
@MartaPintoTeixeira
Copy link
Contributor

"We promote diversity" should be sd-headline size 4xl please

@smfonseca smfonseca removed their assignment Jan 7, 2025
mariohamann
mariohamann reviewed Jan 9, 2025
View reviewed changes
packages/docs/src/stories/templates/flipcard.stories.ts
>
<h5 slot="front" class="sd-headline sd-headline--inverted sd-headline--size-lg p-5">
We are invested in over USD 6 Billion of Assets under Management
</h5>
<div slot="back" class="w-full sd-prose sd-prose--inverted p-5">
<h3 class="sd-headline sd-headline--size-lg sd-headline--inverted">Our quality portfolio</h3>
<div slot="back" class="w-full sd-prose p-5">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need sd-prose if you style everything?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not manually forcing any margins on this flipcard, the sd-prose is doing it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yah. I'm just curious, if you could omit e. g. sd-headline sd-headline--size-lg sd-headline--inverted when you just have sd-prose sd-prose--inverted?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just tested it and using sd-prose sd-prose--inverted does not invert the sd-headline.

Should we create a ticket for this?

@karlbaumhauer karlbaumhauer removed their assignment Jan 10, 2025
@coraliefeil coraliefeil removed their assignment Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariohamann mariohamann mariohamann left review comments

@MartaPintoTeixeira MartaPintoTeixeira MartaPintoTeixeira approved these changes

@smfonseca smfonseca smfonseca approved these changes

Assignees

@mariohamann mariohamann

@paulovareiro29 paulovareiro29

@auroraVasconcelos auroraVasconcelos

@MartaPintoTeixeira MartaPintoTeixeira

Labels
None yet
Projects
Solid Design System Project Board
Status: 👀 In review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat[dev]: ✨ implement A11y improvements for Flipcard Template
7 participants
@paulovareiro29 @MartaPintoTeixeira @mariohamann @smfonseca @coraliefeil @karlbaumhauer @auroraVasconcelos