NH-65512: try to fix the in_span issue

test/api/opentelemetry_inspan_test.rb

@@ -3,52 +3,73 @@
 
 require 'minitest_helper'
 require './lib/solarwinds_apm/api'
+# act -j unit_test --container-architecture linux/arm64 -s SW_APM_SERVICE_KEY=your_key
+# 
 
 describe 'SolarWinds Set Transaction Name Test' do
   before do
-    ENV['OTEL_SERVICE_NAME'] = 'my_service'
     @op = -> { 10.times {[9, 6, 12, 2, 7, 1, 9, 3, 4, 14, 5, 8].sort} }
-    @in_memory_exporter = CustomInMemorySpanExporter.new(recording: false)
+  end
+
+  it 'test_in_span_wrapper_from_solarwinds_apm' do
 
+    in_memory_exporter = ::OpenTelemetry::SDK::Trace::Export::InMemorySpanExporter.new
     OpenTelemetry::SDK.configure do |c|
-      c.service_name = 'my_service'
-      c.add_span_processor(::OpenTelemetry::SDK::Trace::Export::SimpleSpanProcessor.new(@in_memory_exporter))
+      c.service_name = 'test_in_span_wrapper_from_solarwinds_apm'
+      c.add_span_processor(
+        ::OpenTelemetry::SDK::Trace::Export::SimpleSpanProcessor.new(
+          in_memory_exporter))
     end
-  end
 
-  after do
-    ENV['OTEL_SERVICE_NAME'] = nil
-  end
-
-  it 'test_in_span_wrapper_from_solarwinds_apm' do
-    @in_memory_exporter.recording = true
     SolarWindsAPM::API.in_span('custom_span') do
       @op.call
     end
 
-    finished_spans = @in_memory_exporter.finished_spans
+    finished_spans = extract_span(in_memory_exporter)
 
     _(finished_spans.first.name).must_equal 'custom_span'
+
+    in_memory_exporter.shutdown
   end
 
   it 'test_in_span_wrapper_from_solarwinds_apm_with_span' do
-    @in_memory_exporter.recording = true
+
+    in_memory_exporter = ::OpenTelemetry::SDK::Trace::Export::InMemorySpanExporter.new
+    OpenTelemetry::SDK.configure do |c|
+      c.service_name = 'test_in_span_wrapper_from_solarwinds_apm_with_span'
+      c.add_span_processor(
+        ::OpenTelemetry::SDK::Trace::Export::SimpleSpanProcessor.new(
+          in_memory_exporter))
+    end
+
     SolarWindsAPM::API.in_span('custom_span') do |span|
       span.add_attributes({"test_attribute" => "attribute_1"})
       @op.call
     end
 
-    finished_spans = @in_memory_exporter.finished_spans
+    finished_spans = extract_span(in_memory_exporter)
 
     _(finished_spans.first.name).must_equal 'custom_span'
     _(finished_spans.first.attributes['test_attribute']).must_equal 'attribute_1'
+
+    in_memory_exporter.shutdown
   end
 
   it 'test_in_span_wrapper_from_solarwinds_apm_without_block' do
-    @in_memory_exporter.recording = true
+
+    in_memory_exporter = ::OpenTelemetry::SDK::Trace::Export::InMemorySpanExporter.new
+    OpenTelemetry::SDK.configure do |c|
+      c.service_name = 'test_in_span_wrapper_from_solarwinds_apm'
+      c.add_span_processor(
+        ::OpenTelemetry::SDK::Trace::Export::SimpleSpanProcessor.new(
+          in_memory_exporter))
+    end
+
     SolarWindsAPM::API.in_span('custom_span')
 
-    finished_spans = @in_memory_exporter.finished_spans
+    finished_spans = extract_span(in_memory_exporter)
     _(finished_spans.size).must_equal 0
+
+    in_memory_exporter.shutdown
   end
 end

test/minitest_helper.rb

@@ -186,6 +186,27 @@
   end
 end
 
+
+##
+# extract_span
+#
+# get finished_span from exporter that overcome time issue
+#
+def extract_span(exporter)
+  finished_spans = []
+  retry_count    = 5
+  while finished_spans.size == 0
+
+    break if retry_count > 5
+
+    finished_spans = exporter.finished_spans
+    retry_count   += 1
+    sleep retry_count
+  end
+
+  finished_spans
+end
+
 ##
 # create_span_data
 #