Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NH-65512: try to fix the in_span issue #87

Merged
merged 6 commits into from
Oct 26, 2023
Merged

NH-65512: try to fix the in_span issue #87

merged 6 commits into from
Oct 26, 2023

Conversation

xuan-cao-swi
Copy link
Contributor

Description

Attempt to fix the test case failure on solarwinds_apm wrapper on in_span

test/minitest_helper.rb Fixed Show fixed Hide fixed
test/minitest_helper.rb Fixed Show fixed Hide fixed
@xuan-cao-swi xuan-cao-swi requested a review from a team October 25, 2023 21:23
Copy link
Contributor

@cheempz cheempz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with one change request @xuan-cao-swi.

test/api/opentelemetry_inspan_test.rb Outdated Show resolved Hide resolved
@xuan-cao-swi xuan-cao-swi requested a review from cheempz October 26, 2023 14:20
Copy link
Contributor

@cheempz cheempz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xuan-cao-swi xuan-cao-swi merged commit 229b8cf into main Oct 26, 2023
12 checks passed
@xuan-cao-swi xuan-cao-swi deleted the NH-65512 branch October 26, 2023 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants