-
-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various fixes #840
Merged
Merged
Various fixes #840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the bankingCycleRewardMultiplier constant. This change fixes the UI showing an incorrect Cycle Income value on the player info panel when in the January flux (banking rewards multiplier reduced from 75 to 50).
* Fixed incorrect comment description of January flux.
cde7420
to
f13fde3
Compare
…ectly calculated: - localeCompare() return value was incorrectly being treated as a boolean instead of a number. - distance calculation was being returned a boolean instead of the difference. This change fixes stars and carriers being listed in the wrong order on the Select Objects panel. Stars and carriers should now be listed in the following order: * stars by whichever was closest to mouse/tap location. Stars of equal distance from the mouse/tap location will be ordered by name. * carriers by whichever was closest to mouse/tap location. Carriers of equal distance from the mouse/tap location will be ordered by name This behaviour aligns with what I believe was the intention of the original code.
…ding the carrier after changes have been saved. This fixes waypoint paths not reflecting if they were looped or unlooped when adjusted from the Edit Fleet Order panel. * Updated CarrierWaypoint component to emit confirmation sound when saving waypoints, matching the behaviour of the CarrierWaypoints component.
- Added functionality to ensure that the values of starShips and carrierShips are parsed ints. This fixes the issue where, if the user entered a manual value for the number of ships, subsequent use of the ship transfer buttons would appear to append the values the numbers were supposed to be adding to the ships as a string, instead of adding them like numbers. - Prevented the modals from allowing the user to submit the panel when 0 ships are assigned to the carrier. This fixes the issue where, if the user entered a value of 0 for the number of carrier ships, the Transfer/Build buttons would still be clickable but nothing would happen. - Updated to respond immediately to user input to allow for a smoother experience when specifying the number of ships to be transferred. * Updated LedgerRow component to use the correct property in the response object to assign to the value of ledger.debt. This fixes the issue where ledger row would sometimes show $undefined instead of the debt value when settling or forgiving debt. * Updated SelectAlias (and EnterPassword, for consistency) component to use `@change` for handling input events instead of v-on:keyup. This fixes that pesky issue where, when joining a game from a phone (eg an Android phone), if you had a name with spaces, the game would sometimes not pick up the part after the last space. There's no keyup event for it to pick up, so it would only pick up changes when there were spaces.
Awesome 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
################################
This change fixes stars and carriers being listed in the wrong order on the Select Objects panel. Stars and carriers should now be listed in the following order:
This behaviour aligns with what I believe was the intention of the original code.
################################
@change
for handling input events instead of v-on:keyup. This fixes that pesky issue where, when joining a game from a phone (eg an Android phone), if you had a name with spaces, the game would sometimes not pick up the part after the last space. There's no keyup event for it to pick up, so it would only pick up changes when there were spaces.