Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various fixes #840

Merged
merged 7 commits into from
Mar 5, 2024
Merged

Conversation

Metritutus
Copy link
Collaborator

@Metritutus Metritutus commented Feb 28, 2024

  • Fixed _getBankingCredits() method in client's GameHelper not using the bankingCycleRewardMultiplier constant. This change fixes the UI showing an incorrect Cycle Income value on the player info panel when in the January flux (banking rewards multiplier reduced from 75 to 50).
  • Updated .gitignore to exclude .vs and build folders.
  • Fixed incorrect comment description of January flux.
    ################################
  • Updated tryMultiSelect() in map.js to fix closeObjects being incorrectly calculated:
    • localeCompare() return value was incorrectly being treated as a boolean instead of a number.
    • distance calculation was being returned a boolean instead of the difference.

This change fixes stars and carriers being listed in the wrong order on the Select Objects panel. Stars and carriers should now be listed in the following order:

  • stars by whichever was closest to mouse/tap location. Stars of equal distance from the mouse/tap location will be ordered by name.
  • carriers by whichever was closest to mouse/tap location. Carriers of equal distance from the mouse/tap location will be ordered by name

This behaviour aligns with what I believe was the intention of the original code.
################################

  • Fixed saveWaypoints() method of CarrierWaypoint component not reloading the carrier after changes have been saved. This fixes waypoint paths not reflecting if they were looped or unlooped when adjusted from the Edit Fleet Order panel.
  • Updated CarrierWaypoint component to emit confirmation sound when saving waypoints, matching the behaviour of the CarrierWaypoints component.
  • Updated BuildCarrier and ShipTransfer components:
    • Added functionality to ensure that the values of starShips and carrierShips are parsed ints. This fixes the issue where, if the user entered a manual value for the number of ships, subsequent use of the ship transfer buttons would appear to append the values the numbers were supposed to be adding to the ships as a string, instead of adding them like numbers.
    • Prevented the modals from allowing the user to submit the panel when 0 ships are assigned to the carrier. This fixes the issue where, if the user entered a value of 0 for the number of carrier ships, the Transfer/Build buttons would still be clickable but nothing would happen.
    • Updated to respond immediately to user input to allow for a smoother experience when specifying the number of ships to be transferred.
  • Updated LedgerRow component to use the correct property in the response object to assign to the value of ledger.debt. This fixes the issue where ledger row would sometimes show $undefined instead of the debt value when settling or forgiving debt.
  • Updated SelectAlias (and EnterPassword, for consistency) component to use @change for handling input events instead of v-on:keyup. This fixes that pesky issue where, when joining a game from a phone (eg an Android phone), if you had a name with spaces, the game would sometimes not pick up the part after the last space. There's no keyup event for it to pick up, so it would only pick up changes when there were spaces.

SpacialCircumstances and others added 4 commits February 22, 2024 23:54
…the bankingCycleRewardMultiplier constant. This change fixes the UI showing an incorrect Cycle Income value on the player info panel when in the January flux (banking rewards multiplier reduced from 75 to 50).
* Fixed incorrect comment description of January flux.
@Metritutus Metritutus force-pushed the fixes001 branch 3 times, most recently from cde7420 to f13fde3 Compare February 29, 2024 20:29
…ectly calculated:

    - localeCompare() return value was incorrectly being treated as a boolean instead of a number.
    - distance calculation was being returned a boolean instead of the difference.

This change fixes stars and carriers being listed in the wrong order on the Select Objects panel.  Stars and carriers should now be listed in the following order:
* stars by whichever was closest to mouse/tap location.  Stars of equal distance from the mouse/tap location will be ordered by name.
* carriers by whichever was closest to mouse/tap location.  Carriers of equal distance from the mouse/tap location will be ordered by name

This behaviour aligns with what I believe was the intention of the original code.
…ding the carrier after changes have been saved. This fixes waypoint paths not reflecting if they were looped or unlooped when adjusted from the Edit Fleet Order panel.

* Updated CarrierWaypoint component to emit confirmation sound when saving waypoints, matching the behaviour of the CarrierWaypoints component.
    - Added functionality to ensure that the values of starShips and carrierShips are parsed ints.  This fixes the issue where, if the user entered a manual value for the number of ships, subsequent use of the ship transfer buttons would appear to append the values the numbers were supposed to be adding to the ships as a string, instead of adding them like numbers.
    - Prevented the modals from allowing the user to submit the panel when 0 ships are assigned to the carrier.  This fixes the issue where, if the user entered a value of 0 for the number of carrier ships, the Transfer/Build buttons would still be clickable but nothing would happen.
    - Updated to respond immediately to user input to allow for a smoother experience when specifying the number of ships to be transferred.
* Updated LedgerRow component to use the correct property in the response object to assign to the value of ledger.debt.  This fixes the issue where ledger row would sometimes show $undefined instead of the debt value when settling or forgiving debt.
* Updated SelectAlias (and EnterPassword, for consistency) component to use `@change` for handling input events instead of v-on:keyup.  This fixes that pesky issue where, when joining a game from a phone (eg an Android phone), if you had a name with spaces, the game would sometimes not pick up the part after the last space.  There's no keyup event for it to pick up, so it would only pick up changes when there were spaces.
@SpacialCircumstances SpacialCircumstances changed the base branch from master to dev March 5, 2024 22:13
@SpacialCircumstances
Copy link
Member

Awesome 👍

@SpacialCircumstances SpacialCircumstances merged commit 1b5970f into solaris-games:dev Mar 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants