-
-
Notifications
You must be signed in to change notification settings - Fork 67
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
* Updated BuildCarrier and ShipTransfer components:
- Added functionality to ensure that the values of starShips and carrierShips are parsed ints. This fixes the issue where, if the user entered a manual value for the number of ships, subsequent use of the ship transfer buttons would appear to append the values the numbers were supposed to be adding to the ships as a string, instead of adding them like numbers. - Prevented the modals from allowing the user to submit the panel when 0 ships are assigned to the carrier. This fixes the issue where, if the user entered a value of 0 for the number of carrier ships, the Transfer/Build buttons would still be clickable but nothing would happen. - Updated to respond immediately to user input to allow for a smoother experience when specifying the number of ships to be transferred. * Updated LedgerRow component to use the correct property in the response object to assign to the value of ledger.debt. This fixes the issue where ledger row would sometimes show $undefined instead of the debt value when settling or forgiving debt. * Updated SelectAlias (and EnterPassword, for consistency) component to use `@change` for handling input events instead of v-on:keyup. This fixes that pesky issue where, when joining a game from a phone (eg an Android phone), if you had a name with spaces, the game would sometimes not pick up the part after the last space. There's no keyup event for it to pick up, so it would only pick up changes when there were spaces.
- Loading branch information
1 parent
cbf2275
commit d47b380
Showing
5 changed files
with
44 additions
and
20 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters