-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Crypto Polyfill, Update Links, Refactor Code, and Improve Android SDK Guidance #403
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has many useful bits especially around the Android SDK but needs significant changes to be merged. In particular, not using metaplex-foundation/js
is one of the reasons this bounty was created. See the comments inline.
If those are fixed, however, we can get this in.
Please do not open a 3rd PR. Just update your branch with the fixes so we can see them being fixed here.
return formatDate(new Date(Date.now())) === nft.name; | ||
}); | ||
|
||
if (nftOfTheDayIndex !== -1) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'Does not equal -1' is very old-style JS. Why not do const nftOfTheDay = loadedNFTs.find((loadedNft) => { ... })
and then if ( ! loadedNft ) {}
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but that will make the condition false
}); | ||
|
||
const data = await response.json(); | ||
const cid = data.value.cid; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is a cid
? Don't answer, just name this better. See https://github.com/solana-foundation/developer-content/blob/main/CONTRIBUTING.md#code re: use full names.
Problem Statement
Summary of Changes
Additional Notes