refactor: solana-mobile-dapps-with-expo.md #390
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
1. The crypto-browserify polyfill was throwing compile errors and is not actively maintained.
2. Some hyperlinks referenced in the lesson are broken.
3. Code snippets used for demonstration needed refactoring.
4. Lesson lacks some general Android SDK troubleshooting.
5. The buffer polyfill was not at the top of the entry file and threw an error when compiling the app.
Summary of Changes
1. Added react-native-quick-crypto for native crypto polyfilling as this package is actively maintained.
2. Fixed the broken hyperlinks.
3. Refactored some code snippets by better error handling using try-catch.
4. Added troubleshooting for NDK unavailability in the client machine.
6. Added necessary configurations for babel.config.js.
7. Separated polyfill code to a separate file for better code presentation and imported it at the top of the entry file.
8. added yarn scripts for packages installation