-
Notifications
You must be signed in to change notification settings - Fork 87
Support Ledger clear signing #1603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
franciszekjob
wants to merge
40
commits into
development
Choose a base branch
from
1473-update-ledger-signer
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+723
−579
Open
Changes from all commits
Commits
Show all changes
40 commits
Select commit
Hold shift + click to select a range
ffa255f
Update SHAs for ledger repos
franciszekjob 27d2d66
Add blind-signing allowance script
franciszekjob 4cd9c84
Implement clear signing
franciszekjob 8494f0d
Add client fixture with predeclared argent accounts
franciszekjob f1d158a
Update tests and automation rules
franciszekjob 0d254cc
update automation rules
franciszekjob b208ea6
Update `poetry.lock`
franciszekjob 844f410
Fix typechecks
franciszekjob b7ad26c
Fir formatting
franciszekjob 9022364
Update docs
franciszekjob ccdee97
Refactor call encoding
franciszekjob 55e6042
Add docstrings for `LedgerSigningMode`
franciszekjob f90450e
Include `LedgerSigningMode` in docs
franciszekjob c94b837
Update migration guide
franciszekjob b4d2619
Fix linting
franciszekjob 02bf3c4
Fix `Build the app inside Docker container` step
franciszekjob 6a29cea
Fix typo
franciszekjob 1d6a784
Update port
franciszekjob ad39434
Remove "Reject" automation rule
franciszekjob 0cd5287
Fix automation rules
franciszekjob 7e237e8
Formatting
franciszekjob 95468d1
Update order of automation rules
franciszekjob 80807cd
Trigger CI
franciszekjob b31777b
Temporarily skip `test_deploy_account_and_transfer`
franciszekjob 6a285a6
Temporarily skip `test_create_account_with_ledger_signer`
franciszekjob c7fcf72
Temporarily skip rest of ledger tests
franciszekjob 8164c03
Fix automation rules
franciszekjob b001bb4
Apply code review suggestions
franciszekjob d20ff65
Bump devnet
franciszekjob a8f8a9c
Merge branch 'development' of https://github.com/software-mansion/sta…
franciszekjob e518de7
Fix typo
franciszekjob bafe1a0
Always predeclare argent
franciszekjob 37f7dc9
Revert "Always predeclare argent"
franciszekjob a38ba8f
Fix typo
franciszekjob 740a8ec
Always predeclare argent accounts
franciszekjob 9a02447
Fix linting
franciszekjob 96eafcd
Apply code review suggestions
franciszekjob ec7a68e
Add `test_invoke_v3_long_calldata`
franciszekjob 9cd1d5e
Apply code review suggestion
franciszekjob 7dec2c5
Update automation rules
franciszekjob File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -32,7 +32,6 @@ docs = [ | |
] | ||
ledger = [ | ||
"ledgerwallet>=0.5.0,<1.0.0", | ||
"bip-utils>=2.9.3,<3.0.0", | ||
] | ||
|
||
[project.urls] | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note: These variables aren't used across multiple files so let's keep them in the dedicated (ledger) one.