Support Ledger clear signing #1603
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franciszekjob
commented
May 12, 2025
franciszekjob
commented
May 12, 2025
franciszekjob
commented
May 13, 2025
franciszekjob
commented
May 13, 2025
franciszekjob
commented
May 13, 2025
ddoktorski
reviewed
May 15, 2025
ddoktorski
reviewed
May 16, 2025
ddoktorski
reviewed
May 16, 2025
| response = self.app.client.apdu_exchange( | ||
| ins=3, | ||
| data=bytes(calldatas[0]), | ||
| p1=6, |
There was a problem hiding this comment.
Why is it 6 not 5?
https://github.com/LedgerHQ/app-starknet/blob/develop/docs/apdu.md#new-call
There was a problem hiding this comment.
I think it's a typo - look that p1 is 5 here. Will add an issue in their repo for that.
There was a problem hiding this comment.
I think you are right, but it would still be good to get confirmation from them.
There was a problem hiding this comment.
ddoktorski
reviewed
May 18, 2025
| response = self.app.client.apdu_exchange( | ||
| ins=3, | ||
| data=bytes(calldatas[0]), | ||
| p1=6, |
There was a problem hiding this comment.
I think you are right, but it would still be good to get confirmation from them.
ddoktorski
approved these changes
May 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1473
Introduced changes
Add support for clear singing in
LedgerSigner. Now we're getting displayed tx details before approving/rejecting it.LedgerSigningModeclear_sign_example.mov