Skip to content

Support Ledger clear signing #1603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 46 commits into from
May 19, 2025
Merged

Conversation

franciszekjob
Copy link
Collaborator

@franciszekjob franciszekjob commented May 12, 2025

Closes #1473

Introduced changes

Add support for clear singing in LedgerSigner. Now we're getting displayed tx details before approving/rejecting it.

  • Add LedgerSigningMode
  • Use clear signing by default
clear_sign_example.mov

  • This PR contains breaking changes

@franciszekjob franciszekjob marked this pull request as ready for review May 13, 2025 08:05
@franciszekjob franciszekjob requested a review from ddoktorski May 15, 2025 23:40
@franciszekjob franciszekjob requested a review from ddoktorski May 16, 2025 09:06
response = self.app.client.apdu_exchange(
ins=3,
data=bytes(calldatas[0]),
p1=6,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator Author

@franciszekjob franciszekjob May 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's a typo - look that p1 is 5 here. Will add an issue in their repo for that.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you are right, but it would still be good to get confirmation from them.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@franciszekjob franciszekjob requested a review from ddoktorski May 16, 2025 16:09
response = self.app.client.apdu_exchange(
ins=3,
data=bytes(calldatas[0]),
p1=6,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you are right, but it would still be good to get confirmation from them.

@franciszekjob franciszekjob requested a review from ddoktorski May 19, 2025 12:08
@franciszekjob franciszekjob merged commit 4b1ea7f into development May 19, 2025
34 of 37 checks passed
@franciszekjob franciszekjob deleted the 1473-update-ledger-signer branch May 19, 2025 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update LedgerSigner
2 participants