-
Notifications
You must be signed in to change notification settings - Fork 87
Support Ledger clear signing #1603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
response = self.app.client.apdu_exchange( | ||
ins=3, | ||
data=bytes(calldatas[0]), | ||
p1=6, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is it 6 not 5?
https://github.com/LedgerHQ/app-starknet/blob/develop/docs/apdu.md#new-call
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's a typo - look that p1
is 5 here. Will add an issue in their repo for that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you are right, but it would still be good to get confirmation from them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
response = self.app.client.apdu_exchange( | ||
ins=3, | ||
data=bytes(calldatas[0]), | ||
p1=6, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you are right, but it would still be good to get confirmation from them.
Closes #1473
Introduced changes
Add support for clear singing in
LedgerSigner
. Now we're getting displayed tx details before approving/rejecting it.LedgerSigningMode
clear_sign_example.mov