Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ignored test case for dev-deps propagation #1008

Closed
wants to merge 0 commits into from
Closed

Add ignored test case for dev-deps propagation #1008

wants to merge 0 commits into from

Conversation

maciektr
Copy link
Contributor

@maciektr maciektr commented Dec 19, 2023 •
edited
Loading

Stack:

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

@maciektr maciektr mentioned this pull request Dec 19, 2023
Closed
@maciektr maciektr marked this pull request as ready for review December 19, 2023 21:31
@maciektr maciektr mentioned this pull request Dec 27, 2023
Closed
mkaput
mkaput approved these changes Jan 2, 2024
View reviewed changes
Copy link
Member

@mkaput mkaput left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this sounds reasonable.

scarb/tests/metadata.rs Outdated
"x".to_string(),
vec![
"core".to_string(),
"dep2".to_string(),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a comment here stating that without exclusion, there would be dep1 here?

@maciektr maciektr closed this Jan 3, 2024
@maciektr maciektr mentioned this pull request Jan 3, 2024
Merged
@maciektr maciektr deleted the spr/main/d490a79a branch January 3, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkaput mkaput mkaput approved these changes

@tomek0123456789 tomek0123456789 Awaiting requested review from tomek0123456789

@szymmis szymmis Awaiting requested review from szymmis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maciektr @mkaput