-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ignored test case for conflicting deps in unrelated ws members #1007
Conversation
What are those tests related to, especially in the context that they are ignored? |
@szymmis basically bugs that we should sort out eventually |
cfcb40c
to
f1b1184
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do understand the reasoning. I am afraid how this will play out with PubGrub, as I believe the canonical algorithm will attempt to unify some_dep
in this scenario.
Did some user request this behaviour? Do we need to commit to it?
Nope, just a thought experiment
Well, I do not know as well. Though it seems that having same dep with different versions may actually make sense even in cairo - when the graph is disconnected. |
That's a highly philosophical argument. One could want instead to use a single version of |
912ed7b
to
c68fb93
Compare
c68fb93
to
4c52b58
Compare
commit-id:001f9da5
4c52b58
to
efb4c8b
Compare
commit-id:70c8f66b
efb4c8b
to
f67291a
Compare
commit-id:001f9da5 --- **Stack**: - #1007 - #1030 ⬅⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do not merge manually using the UI - doing so may have unexpected results.*
Stack: