-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[All] Clean collision detection in FreeMotionAnimationLoop #5042
[All] Clean collision detection in FreeMotionAnimationLoop #5042
Conversation
…dd them in the animation loops
[ci-build][with-all-tests] |
[ci-build][with-all-tests][force-full-build] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see any implementation of processGeometricalData
. Could you give more details on this function? The documentation is not very helpful
It was introduced by @courtecuisse to be able to perform some processing before the collision detection to speed up the process of proximity computation in his plugins of collision detection. |
Sofa/framework/Simulation/Core/src/sofa/simulation/CollisionVisitor.h
Outdated
Show resolved
Hide resolved
Sofa/framework/Simulation/Core/src/sofa/simulation/CollisionVisitor.h
Outdated
Show resolved
Hide resolved
Sofa/framework/Simulation/Core/src/sofa/simulation/CollisionVisitor.h
Outdated
Show resolved
Hide resolved
…sitor.h Co-authored-by: Hugo <[email protected]>
…sitor.h Co-authored-by: Hugo <[email protected]>
…sitor.h Co-authored-by: Hugo <[email protected]>
The inheritance link between CollisionResetVisitor and CollisionVisitor and some other had a consequence that ProcessGeometricalData was called multiple times in the FreeMotionAnimationLoop when the free motion and the collision detection where computed in parallel.
Another issue was that we had two time the timers for the substeps of the collision detection in the case of parallel computation : IMO only the AnimationLoop should have timers for global computation made by visitors. Here I remove the one of the Pipeline.
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if