Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[All] Clean collision detection in FreeMotionAnimationLoop #5042

Conversation

bakpaul
Copy link
Contributor

@bakpaul bakpaul commented Oct 4, 2024

The inheritance link between CollisionResetVisitor and CollisionVisitor and some other had a consequence that ProcessGeometricalData was called multiple times in the FreeMotionAnimationLoop when the free motion and the collision detection where computed in parallel.

Another issue was that we had two time the timers for the substeps of the collision detection in the case of parallel computation : IMO only the AnimationLoop should have timers for global computation made by visitors. Here I remove the one of the Pipeline.


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@bakpaul bakpaul added pr: status to review To notify reviewers to review this pull-request pr: clean Cleaning the code labels Oct 4, 2024
@bakpaul
Copy link
Contributor Author

bakpaul commented Oct 4, 2024

[ci-build][with-all-tests]

@fredroy
Copy link
Contributor

fredroy commented Oct 15, 2024

[ci-build][with-all-tests][force-full-build]

Copy link
Contributor

@alxbilger alxbilger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any implementation of processGeometricalData. Could you give more details on this function? The documentation is not very helpful

@bakpaul
Copy link
Contributor Author

bakpaul commented Nov 12, 2024

It was introduced by @courtecuisse to be able to perform some processing before the collision detection to speed up the process of proximity computation in his plugins of collision detection.

@bakpaul bakpaul added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Nov 13, 2024
@fredroy fredroy merged commit ba947da into sofa-framework:master Nov 13, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: clean Cleaning the code pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants