Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Constraint.Projective] Make LinearVelocityProjectiveConstraint work with FreeMotionAL #5025

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

[Constraint.Projective] Make LinearVelocityProjectiveConstraint work with FreeMotionAL #5025

wants to merge 6 commits into from

Conversation

bakpaul
Copy link
Contributor

@bakpaul bakpaul commented Sep 26, 2024

Implement missing methods to work in FreeMotionAnimationLoop. --> simply took what was implemented in FixedProjectiveConstraint.

Also add a new feature to keep the constraint applied after all the key event have passed

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).

Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@bakpaul
Implement missing methods to work in FreeMotionAnimationLoop and add …
b264969 
…feature to keep the constraint applied after all the key event have passed
@bakpaul bakpaul added pr: fix Fix a bug pr: status to review To notify reviewers to review this pull-request labels Sep 26, 2024
fredroy
fredroy requested changes Oct 2, 2024
View reviewed changes
Copy link
Contributor

@fredroy fredroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess a scene test (even better with a regression 🥸) would be welcomed 🫢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugtalbot hugtalbot hugtalbot left review comments

@alxbilger alxbilger alxbilger left review comments

@fredroy fredroy fredroy requested changes

Assignees
No one assigned
Labels
pr: fix Fix a bug pr: status to review To notify reviewers to review this pull-request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bakpaul @alxbilger @fredroy @hugtalbot