-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove castore dependency #274
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @wojtekmach !
@sneako actually let's hold off on this for a second, perhaps we should set Mint version requirement to |
Less dependencies is always great 👀 Any way to help this move along? Looks like one failing test 👀 |
The failing line is this one: finch/test/finch/http2/pool_test.exs Line 239 in 047a417
I have determined it started failing after this Mint change, elixir-mint/mint#434, which makes sense, Mint stopped sending frames under some circumstances and the test is expecting these. Perhaps it's as simple as updating the test? cc @v0idpwn |
9c79fa0
to
b78d4d3
Compare
@@ -33,8 +33,7 @@ defmodule Finch.MixProject do | |||
|
|||
defp deps do | |||
[ | |||
{:mint, "~> 1.6"}, | |||
{:castore, "~> 0.1 or ~> 1.0"}, | |||
{:mint, "~> 1.6.2 or ~> 1.7"}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mint is using OS trust store since 1.6.1. I thought I'd require the latest available version at the moment, 1.6.2: https://github.com/elixir-mint/mint/blob/main/CHANGELOG.md#v162.
❤️ |
Closes #178.
Mint was recently updated to automatically use OS trust store: elixir-mint/mint#435.
If we are on OTP 24, we'd receive this error:
Same error when using OTP 25+ but the OS happens not to have certs:
I believe the error is good enough however I'm happy to improve it of course!