Default to using Erlang certificates store #435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The OTP team no longer supports Erlang versions earlier than 25+, so we can assuming that `:public_key.cacerts_get/0` is available and only fallback to `CAStore` if not. This also solves a bug in that Req/Finch/Mint do not work inside escripts by default (because inside an escript you cannot access the priv dir of an application).
|
It would be fantastic to get a new minor version with this change to address this: livebook-dev/livebook#2642 But we can also depend on main if merged. :) |
Pull Request Test Coverage Report for Build 31c9a714a5baa02dcdec2221fc6004efd62571d6-PR-435Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build eeb0c17dfbb5c461ce3bb6ae4669a1823da84362-PR-435Details
💛 - Coveralls |
whatyouhide
reviewed
Jun 8, 2024
| Keyword.put(opts, :cacertfile, CAStore.file_path()) | ||
| try do | ||
| Keyword.put(opts, :cacerts, :public_key.cacerts_get()) | ||
| rescue |
There was a problem hiding this comment.
Should we catch UndefinedFunctionError specifically?
There was a problem hiding this comment.
I believe it is for when running OTP 25 but OS happens not to have certs, cacerts_get() raises then.
|
@josevalim 1.6.1 is out 🙃 |
|
@whatyouhide v1.6.1 is out on GitHub but looks like not yet on Hex! |
|
Thanks! I'm updating Finch accordingly: sneako/finch#274. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The OTP team no longer supports Erlang versions earlier than 25+, so we can assuming that
:public_key.cacerts_get/0is available and only fallback toCAStoreif not.This also solves a bug in that Req/Finch/Mint do not work inside escripts by default (because inside an escript you cannot access the priv dir of an application).