fix: kwargs undefined, likely needs to be kwargs_all #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
problem: the plugin.py registry references kwargs, which is not defined in the location of reference. Likely it needs to be kwargs_all since the if/else it is in checks kwargs_tagged in the top Signed-off-by: vsoch <[email protected]>
johanneskoester
approved these changes
Oct 11, 2023
johanneskoester
pushed a commit
that referenced
this pull request
Oct 11, 2023
🤖 I have created a release *beep* *boop* --- ## [1.11.0](v1.10.0...v1.11.0) (2023-10-11) ### Features * add functionality for converting settings into arguments ([48687f9](48687f9)) ### Bug Fixes * fix handling of plugin settings names ([8007ab4](8007ab4)) * improved handling of tagged settings ([8653e82](8653e82)) * kwargs undefined, likely needs to be kwargs_all ([#25](#25)) ([372fb10](372fb10)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
problem: the plugin.py registry references kwargs, which is not defined in the location of reference. Likely it needs to be kwargs_all since the if/else it is in checks kwargs_tagged in the top