fix: envars default to none will trigger error #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: if a workflow does not have default envvars, the function
get_envvar_declarations will error trying to iterate over a None
object.
Solution: add an or {} to ensure that we do not error.
Signed-off-by: vsoch <[email protected]>
vsoch
force-pushed
the
small-bugfixes-for-flux
branch
from
e07894a to
21090c4
Compare
|
Bug that is breaking tests should be fixed here: snakemake/snakemake-interface-common#25 |
|
Thanks! This has been fixed in the settings class now (it now always gives a sequence, also in the empty case). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: if a workflow does not have default envvars, the function get_envvar_declarations will error trying to iterate over a None object.
Solution: add an or {} to ensure that we do not error.