Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add toggle for dark and light mode - part 2 #107

Merged
merged 26 commits into from
Aug 3, 2023

Conversation

swyxio
Copy link
Contributor

@swyxio swyxio commented Aug 3, 2023

this incorpoates #96 thanks to @eshack94 and @seanoliver

we have some known bugs we decided to fix later:

  • when first opens up, everyone opens to system default, only waiting to keypress to toggle darkmode. this means anthropic, which doesnt have a dark mode, shows up light first while everyone else is dark
  • "toggle dark mode" menubar item isnt perfectly synced with the actual ui darkmode state
    image

dark mode

image

light mode

image

eshack94 and others added 23 commits July 30, 2023 01:21
…dify window hiding function with manual flag, feat(index.js) add double-click on tray for quicker open.
…ctron ipcRenderer, refactor(provider) remove unnecessary white spaces
@swyxio swyxio requested a review from seanoliver August 3, 2023 21:13
@swyxio
Copy link
Contributor Author

swyxio commented Aug 3, 2023

@eshack94 - we are merging in this for now since its kinda working, but please feel free to update your fork and open up another PR if you have futher polish you'd like to do

(im biasing towards quicker merges and shorter lived branches)

@swyxio swyxio merged commit d7c1a77 into main Aug 3, 2023
1 check passed
@eshack94
Copy link
Contributor

eshack94 commented Aug 6, 2023

@swyxio sounds good! I've not had time to look at this in a few days due to the demands of my day-job, so I appreciate you and @seanoliver's help. I'll check out your changes and will open a new feature branch building off of it if needed!

Thanks again!

@swyxio swyxio deleted the add-toggle-for-dark-and-light-mode branch August 16, 2023 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants