Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] Feature - UI - Allow option to toggle light/dark mode #95

Closed
eshack94 opened this issue Jul 29, 2023 · 5 comments
Closed

[Request] Feature - UI - Allow option to toggle light/dark mode #95

eshack94 opened this issue Jul 29, 2023 · 5 comments

Comments

@eshack94
Copy link
Contributor

Request: allow option to toggle light/dark mode

Apologies if this is already available and I missed it. Please let me know where to find it if that's the case.

Also, I can maybe take a stab at adding this myself if someone tells me the relevant files to look at (not too familiar with the codebase).

@swyxio
Copy link
Contributor

swyxio commented Jul 29, 2023

nope not available! you’ll probably want to look at the interface.js and index.js files. theres some css to make each provider dark mode as well inside the providers folder. this isnt a high priority feature for me but if you can figure it out without much guidance youre welcome to work on it

@eshack94
Copy link
Contributor Author

eshack94 commented Jul 30, 2023

Sounds good. I'm working on it now, thanks for the tips. I'll try and get a PR ready for submission this week sometime.

So far I've made changes to index.js and interfaces.js. Next I need to figure out the changes to make to each of the providers files. I'm also thinking about adding a keybinding for the dark mode toggle.

It looks like the providers handle the custom CSS for each of the providers, while index.css handles the CSS for the app menubar app itself? So it looks like I won't need to make changes to index.css, but please correct me if I'm wrong.

Progress report:

in-progress

@eshack94
Copy link
Contributor Author

eshack94 commented Jul 30, 2023

Opened WIP PR and linked to this issue for visibility.

I could use some help figuring out how to find the provider-specific dark mode changes that get made when users enable dark mode on the browser-side. I assume that info is available within browser DevTools somewhere, but I'm not sure where to find it. I'm kind of a JS noob, so apologies for any simple questions.

I'll work more on this PR later this week when I have some free time. I gave maintainers the ability to edit as well.

@swyxio
Copy link
Contributor

swyxio commented Jul 30, 2023

It looks like the providers handle the custom CSS for each of the providers, while index.css handles the CSS for the app menubar app itself? So it looks like I won't need to make changes to index.css, but please correct me if I'm wrong.

correct

I'm also thinking about adding a keybinding for the dark mode toggle.

haha personally i remap cmd+q so that it doesn't quit all tabs (very annoying, never what i intend) and instead inverts color at the OS level. its fast and kinda works as a very rough but instant dark/light mode.

@swyxio
Copy link
Contributor

swyxio commented Aug 9, 2023

this was added in #107

but still not very stable yet i think. needs a bit more testing

@swyxio swyxio closed this as completed Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants