-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: rename components package to smart camera web #140
Merged
tamssokari
merged 8 commits into
main
from
packages/rename-components-to-smart-camera-web
Nov 28, 2023
Merged
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
63cad0e
refactor: rename `components` to `smart-camera-web`
e0f5e9b
ci: modify github workflows for smart-camera-web package
2147702
embed: update package name, dependencies
d9ecbff
refactor: use local path for cross-package dependencies
a9f2cc6
refactor: move combobox component to components package (#141)
tamssokari 3931f3e
refactor: extract totp-consent to components package (#143)
tamssokari 1df7485
docs: update README to reflect packages update
701a0b7
Merge branch 'main' into packages/rename-components-to-smart-camera-web
tamssokari File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,12 +10,12 @@ on: | |
| jobs: | ||
| test: | ||
| uses: ./.github/workflows/test.yml | ||
| components: | ||
| smart-camera-web: | ||
| needs: | ||
| - test | ||
| defaults: | ||
| run: | ||
| working-directory: ./packages/components | ||
| working-directory: ./packages/smart-camera-web | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: checkout code | ||
|
|
@@ -27,9 +27,9 @@ jobs: | |
| - name: build application | ||
| run: npm run build | ||
| - name: set destination directory | ||
| id: set_dest_dir_camera_web | ||
| id: set_dest_dir_smart_camera_web | ||
| run: >- | ||
| echo "DEST_DIR_COMPONENTS=js/preview-$GITHUB_HEAD_REF" >> | ||
| echo "DEST_DIR_SMART_CAMERA_WEB=js/preview-$GITHUB_HEAD_REF" >> | ||
| "$GITHUB_ENV" | ||
| - name: deploy preview to s3 | ||
| uses: jakejarvis/[email protected] | ||
|
|
@@ -42,8 +42,8 @@ jobs: | |
| AWS_ACCESS_KEY_ID: '${{ secrets.AWS_ACCESS_KEY_ID }}' | ||
| AWS_SECRET_ACCESS_KEY: '${{ secrets.AWS_SECRET_ACCESS_KEY }}' | ||
| AWS_REGION: '${{ secrets.AWS_REGION }}' | ||
| SOURCE_DIR: ./packages/components | ||
| DEST_DIR: '${{ env.DEST_DIR_COMPONENTS }}' | ||
| SOURCE_DIR: ./packages/smart-camera-web | ||
| DEST_DIR: '${{ env.DEST_DIR_SMART_CAMERA_WEB }}' | ||
| embed: | ||
| needs: | ||
| - test | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,27 +5,27 @@ on: | |
| jobs: | ||
| test: | ||
| uses: ./.github/workflows/test.yml | ||
| components: | ||
| smart-camera-web: | ||
| needs: [test] | ||
| runs-on: ubuntu-latest | ||
| timeout-minutes: 5 | ||
| defaults: | ||
| run: | ||
| working-directory: ./packages/components | ||
| working-directory: ./packages/smart-camera-web | ||
| steps: | ||
| - name: checkout code | ||
| uses: actions/checkout@v4 | ||
| - name: get-npm-version | ||
| id: package-version | ||
| uses: martinbeentjes/[email protected] | ||
| with: | ||
| path: packages/components | ||
| path: packages/smart-camera-web | ||
| - name: set destination directory | ||
| id: set_destination | ||
| env: | ||
| TAG: ${{ steps.package-version.outputs.current-version }} | ||
| run: | | ||
| echo "DEST_DIR_COMPONENTS=js/v$TAG" >> $GITHUB_OUTPUT | ||
| echo "DEST_DIR_SMART_CAMERA_WEB=js/v$TAG" >> $GITHUB_OUTPUT | ||
| - name: deploy to s3 / cloudfront | ||
| uses: jakejarvis/[email protected] | ||
| with: | ||
|
|
@@ -34,9 +34,9 @@ jobs: | |
| AWS_S3_BUCKET: ${{ secrets.AWS_S3_BUCKET }} | ||
| AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }} | ||
| AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }} | ||
| SOURCE_DIR: ./packages/components | ||
| SOURCE_DIR: ./packages/smart-camera-web | ||
| AWS_REGION: ${{ secrets.AWS_REGION }} | ||
| DEST_DIR: ${{ steps.set_destination.outputs.DEST_DIR_COMPONENTS }} | ||
| DEST_DIR: ${{ steps.set_destination.outputs.DEST_DIR_SMART_CAMERA_WEB }} | ||
| embed: | ||
| needs: [test] | ||
| runs-on: ubuntu-latest | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure about this change? It's going to make publishing a lot more complicated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tested and verified that it uses the local package as we have this set up as a workspace.
I see the concerns around possible version collisions, will test that shortly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested, and returning to file path.
while this is the right direction for workspaces, we need to avoid situations where updates
to workspace packages do not reflect in dependent packages.
for now, local paths are the better option.