refactor: rename components package to smart camera web #140
Conversation
|
This branch has been deployed to s3 / cloudfront. ✅ Preview URL for Smart Camera Web: |
packages/embed/package.json
Outdated
| @@ -27,7 +27,7 @@ | |||
| }, | |||
| "homepage": "https://github.com/smileidentity/hosted-web-integration#readme", | |||
| "dependencies": { | |||
| "@smile_identity/smart-camera-web": "file:../components", | |||
| "@smile_identity/smart-camera-web": "^1.0.2", | |||
There was a problem hiding this comment.
Are you sure about this change? It's going to make publishing a lot more complicated.
There was a problem hiding this comment.
I have tested and verified that it uses the local package as we have this set up as a workspace.
I see the concerns around possible version collisions, will test that shortly.
There was a problem hiding this comment.
tested, and returning to file path.
while this is the right direction for workspaces, we need to avoid situations where updates
to workspace packages do not reflect in dependent packages.
for now, local paths are the better option.
* refactor: move combobox component to components package * ci: deploy preview on PRs to all branches * deps: add `@smileid/components` as dependency of `@smileid/embed` * refactor: use local paths for workspace dependencies * refactor: extract `end-user-consent` component to `components` package (#142)
* refactor: move combobox component to components package * ci: deploy preview on PRs to all branches * deps: add `@smileid/components` as dependency of `@smileid/embed` * refactor: extract `end-user-consent` component to `components` package * refactor: extract totp-consent to components package * refactor: use `<totp-consent>` as the markup * refactor: rename `totp-consent` in tests
tamssokari
deleted the
packages/rename-components-to-smart-camera-web
branch
No description provided.