Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deployment): add test helpers for changesets using the new mcms lib #16403

Merged
merged 1 commit into from
Feb 14, 2025
Merged

chore(deployment): add test helpers for changesets using the new mcms lib #16403

merged 1 commit into from
Feb 14, 2025
+126 −0

Conversation

gustavogama-cll
Copy link
Contributor

Add a handful of helpers functions to ease the task of writing tests for changesets that use the new MCMS library.

@gustavogama-cll gustavogama-cll mentioned this pull request Feb 13, 2025
Closed
@cl-sonarqube-production
Copy link

cl-sonarqube-production bot commented Feb 13, 2025 •
edited
Loading

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
5 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@gustavogama-cll gustavogama-cll marked this pull request as ready for review February 14, 2025 01:48
@gustavogama-cll gustavogama-cll requested review from a team as code owners February 14, 2025 01:48
graham-chainlink
graham-chainlink approved these changes Feb 14, 2025
View reviewed changes
Copy link
Collaborator

@graham-chainlink graham-chainlink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i was just looking for this.

This was referenced Feb 14, 2025
Merged
Closed
@ChrisAmora ChrisAmora added this pull request to the merge queue Feb 14, 2025
Merged via the queue into develop with commit 09fa718 Feb 14, 2025
180 checks passed
@ChrisAmora ChrisAmora deleted the ggama/chore-deployment-new-mcms-helpers branch February 14, 2025 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ecPablo ecPablo ecPablo approved these changes

@graham-chainlink graham-chainlink graham-chainlink approved these changes

@winder winder Awaiting requested review from winder winder is a code owner automatically assigned from smartcontractkit/ccip-offchain

@asoliman92 asoliman92 Awaiting requested review from asoliman92 asoliman92 is a code owner automatically assigned from smartcontractkit/ccip-offchain

@makramkd makramkd Awaiting requested review from makramkd makramkd is a code owner automatically assigned from smartcontractkit/ccip-offchain

@dimkouv dimkouv Awaiting requested review from dimkouv dimkouv is a code owner automatically assigned from smartcontractkit/ccip-offchain

@mateusz-sekara mateusz-sekara Awaiting requested review from mateusz-sekara mateusz-sekara is a code owner automatically assigned from smartcontractkit/ccip-offchain

@0xAustinWang 0xAustinWang Awaiting requested review from 0xAustinWang 0xAustinWang is a code owner automatically assigned from smartcontractkit/ccip-offchain

@b-gopalswami b-gopalswami Awaiting requested review from b-gopalswami b-gopalswami is a code owner automatically assigned from smartcontractkit/ccip-offchain

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gustavogama-cll @ecPablo @graham-chainlink @ChrisAmora