Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DPA-1525] solana ccip transfer ownership to timelock #16246

Merged
merged 1 commit into from
Feb 17, 2025

Conversation

ecPablo
Copy link
Contributor

@ecPablo ecPablo commented Feb 5, 2025

https://smartcontract-it.atlassian.net/browse/DPA-1525

Adds the changeset to transfer ownership of CCIP solana programs. Should be merged after

TODO:

  • Add Offramp Transfer
  • Add Timelock Execution to tests

AI Summary

This pull request includes several changes to the deployment/ccip/changeset package, focusing on improvements and updates to the Solana chain contracts and related tests. The most important changes include updating import statements, modifying function parameters, and adding new functions for initializing and deploying contracts. Additionally, there are updates to the test files to reflect these changes.

Changes to Solana Chain Contracts:

  • Import Statements:

    • Reordered and grouped import statements in cs_chain_contracts.go and cs_deploy_chain.go for better organization. [1] [2]
  • Function Modifications:

    • Updated validateRemoteChain function to use chainState.Timelock.ProgramID.String() instead of chainState.Timelock.
    • Modified DefaultFeeQuoterDestChainConfig function to accept an optional destChainSelector parameter and added logic to handle Solana chain selectors. [1] [2]
    • Added feeQuoterAddress parameter to initializeRouter function and updated its logic accordingly. [1] [2] [3]
  • New Functions:

    • Introduced initializeFeeQuoter function to initialize the fee quoter for Solana chains.

Changes to Tests:

  • Import Statements:

    • Updated import statements in cs_chain_contracts_test.go to include new dependencies and remove unused ones.
  • Function Updates:

    • Updated TestAddRemoteChain and TestAddTokenPool functions to align with the changes in the main codebase, including the use of new structures and configuration parameters. [1] [2] [3] [4]
    • Added context initialization in TestAddTokenPool and TestBilling functions. [1] [2]

@ecPablo ecPablo changed the base branch from develop to deploy-transferable-solana February 5, 2025 22:10
@ecPablo ecPablo changed the base branch from deploy-transferable-solana to develop February 5, 2025 22:11
Copy link
Contributor

github-actions bot commented Feb 5, 2025

AER Report: CI Core ran successfully ✅

aer_workflow , commit

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

@ecPablo ecPablo changed the base branch from develop to deploy-transferable-solana February 7, 2025 14:36
Base automatically changed from deploy-transferable-solana to develop February 10, 2025 18:17
Copy link
Contributor

Flakeguard Summary

Ran new or updated tests between develop and ba22e04 (ecpablo/solana-ccip-transfer-ownership).

View Flaky Detector Details | Compare Changes

Found Flaky Tests ❌

1 Results
Name Pass Ratio Panicked? Timed Out? Race? Runs Successes Failures Skips Package Package Panicked? Avg Duration Code Owners
TestDeployerGroupMCMS 0% true true false 3 0 3 0 github.com/smartcontractkit/chainlink/deployment/ccip/changeset true 0s @smartcontractkit/ccip-tooling, @smartcontractkit/ccip-offchain, @smartcontractkit/deployment-automation

Artifacts

For detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json.

@ecPablo ecPablo changed the base branch from develop to ggama/solana-mcms-deploy February 12, 2025 19:09
@ecPablo ecPablo marked this pull request as ready for review February 12, 2025 20:58
@ecPablo ecPablo requested review from a team as code owners February 12, 2025 20:58
@ecPablo ecPablo requested review from ilija42, winder, asoliman92, makramkd, dimkouv, mateusz-sekara, 0xAustinWang and b-gopalswami and removed request for a team February 12, 2025 20:58
tt-cll
tt-cll previously approved these changes Feb 15, 2025
@ecPablo ecPablo marked this pull request as draft February 17, 2025 14:08
auto-merge was automatically disabled February 17, 2025 14:08

Pull request was converted to draft

@ecPablo ecPablo marked this pull request as ready for review February 17, 2025 14:09
@ecPablo ecPablo force-pushed the ecpablo/solana-ccip-transfer-ownership branch from b6a100b to 2f28357 Compare February 17, 2025 14:25
@graham-chainlink graham-chainlink added this pull request to the merge queue Feb 17, 2025
Merged via the queue into develop with commit d96c444 Feb 17, 2025
601 of 607 checks passed
@graham-chainlink graham-chainlink deleted the ecpablo/solana-ccip-transfer-ownership branch February 17, 2025 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants