-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DPA-1525] solana ccip transfer ownership to timelock #16246
[DPA-1525] solana ccip transfer ownership to timelock #16246
Conversation
AER Report: CI Core ran successfully ✅AER Report: Operator UI CI ran successfully ✅ |
Flakeguard SummaryRan new or updated tests between View Flaky Detector Details | Compare Changes Found Flaky Tests ❌1 Results
ArtifactsFor detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json. |
6781d0e
Pull request was converted to draft
b6a100b
to
2f28357
Compare
|
https://smartcontract-it.atlassian.net/browse/DPA-1525
Adds the changeset to transfer ownership of CCIP solana programs. Should be merged after
TODO:
AI Summary
This pull request includes several changes to the
deployment/ccip/changeset
package, focusing on improvements and updates to the Solana chain contracts and related tests. The most important changes include updating import statements, modifying function parameters, and adding new functions for initializing and deploying contracts. Additionally, there are updates to the test files to reflect these changes.Changes to Solana Chain Contracts:
Import Statements:
cs_chain_contracts.go
andcs_deploy_chain.go
for better organization. [1] [2]Function Modifications:
validateRemoteChain
function to usechainState.Timelock.ProgramID.String()
instead ofchainState.Timelock
.DefaultFeeQuoterDestChainConfig
function to accept an optionaldestChainSelector
parameter and added logic to handle Solana chain selectors. [1] [2]feeQuoterAddress
parameter toinitializeRouter
function and updated its logic accordingly. [1] [2] [3]New Functions:
initializeFeeQuoter
function to initialize the fee quoter for Solana chains.Changes to Tests:
Import Statements:
cs_chain_contracts_test.go
to include new dependencies and remove unused ones.Function Updates:
TestAddRemoteChain
andTestAddTokenPool
functions to align with the changes in the main codebase, including the use of new structures and configuration parameters. [1] [2] [3] [4]TestAddTokenPool
andTestBilling
functions. [1] [2]