Non-E2E Contract Reader Bug Fixes #1099
Merged
+72
−98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EasterTheBunny
temporarily deployed
to
integration
GitHub Actions
Inactive
EasterTheBunny
temporarily deployed
to
integration
GitHub Actions
Inactive
EasterTheBunny
temporarily deployed
to
integration
GitHub Actions
Inactive
EasterTheBunny
temporarily deployed
to
integration
GitHub Actions
Inactive
EasterTheBunny
temporarily deployed
to
integration
GitHub Actions
Inactive
This was referenced Feb 21, 2025
reductionista
previously approved these changes
Feb 21, 2025
EasterTheBunny
temporarily deployed
to
integration
GitHub Actions
Inactive
EasterTheBunny
temporarily deployed
to
integration
GitHub Actions
Inactive
EasterTheBunny
temporarily deployed
to
integration
GitHub Actions
Inactive
EasterTheBunny
temporarily deployed
to
integration
GitHub Actions
Inactive
EasterTheBunny
temporarily deployed
to
integration
GitHub Actions
Inactive
jadepark-dev
previously approved these changes
Feb 24, 2025
| if _, ok := eventMap[idx]; ok { | ||
| continue | ||
| } | ||
|
|
There was a problem hiding this comment.
Why are we not decoding results for event reads here? Are they already decoded somewhere?
There was a problem hiding this comment.
The event reads are decoded by the event binding.
EasterTheBunny
force-pushed
the
NONEVM-1064/bug-fixes
branch
from
0e885d3 to
de50b20
Compare
EasterTheBunny
temporarily deployed
to
integration
GitHub Actions
Inactive
EasterTheBunny
temporarily deployed
to
integration
GitHub Actions
Inactive
EasterTheBunny
temporarily deployed
to
integration
GitHub Actions
Inactive
EasterTheBunny
temporarily deployed
to
integration
GitHub Actions
Inactive
EasterTheBunny
temporarily deployed
to
integration
GitHub Actions
Inactive
reductionista
approved these changes
Feb 24, 2025
jadepark-dev
approved these changes
Feb 24, 2025
jadepark-dev
temporarily deployed
to
integration
GitHub Actions
Inactive
jadepark-dev
temporarily deployed
to
integration
GitHub Actions
Inactive
jadepark-dev
temporarily deployed
to
integration
GitHub Actions
Inactive
jadepark-dev
temporarily deployed
to
integration
GitHub Actions
Inactive
jadepark-dev
temporarily deployed
to
integration
GitHub Actions
Inactive
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR focuses on strictly bug fixes apart from integration tests that were not essential for E2E testing of CCIP.
NONEVM-1064
Requires Dependencies