Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nonevm 1064/querykey integration tests #1084

Draft
wants to merge 18 commits into
base: develop
Choose a base branch
from
Draft

Nonevm 1064/querykey integration tests #1084

wants to merge 18 commits into from
+407 −114

Conversation

EasterTheBunny
Copy link
Contributor

@EasterTheBunny EasterTheBunny commented Feb 17, 2025 •
edited
Loading

@EasterTheBunny EasterTheBunny force-pushed the NONEVM-1064/querykey-integration-tests branch from 911ccd8 to de7d51f Compare February 17, 2025 21:17
@EasterTheBunny EasterTheBunny mentioned this pull request Feb 18, 2025
Merged
@EasterTheBunny EasterTheBunny force-pushed the NONEVM-1064/querykey-integration-tests branch from 91ab620 to 441c68d Compare February 18, 2025 17:54
@EasterTheBunny EasterTheBunny force-pushed the NONEVM-1064/querykey-integration-tests branch from 441c68d to 783f0d5 Compare February 18, 2025 18:05
@EasterTheBunny EasterTheBunny changed the base branch from develop to etb/chainreader-writer-bug-fixes February 18, 2025 18:05
@EasterTheBunny EasterTheBunny force-pushed the NONEVM-1064/querykey-integration-tests branch from 783f0d5 to 2aa136f Compare February 19, 2025 01:13
@EasterTheBunny EasterTheBunny changed the base branch from develop to NONEVM-1064/bug-fixes February 21, 2025 16:00
@EasterTheBunny EasterTheBunny force-pushed the NONEVM-1064/querykey-integration-tests branch from e4145d3 to b5e8e94 Compare February 21, 2025 19:44
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube

reductionista
reductionista previously approved these changes Feb 24, 2025
View reviewed changes
Copy link
Contributor

@reductionista reductionista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, aside from the tests not being able to run in parallel

Base automatically changed from NONEVM-1064/bug-fixes to develop February 24, 2025 22:59
@jadepark-dev jadepark-dev dismissed reductionista’s stale review February 24, 2025 22:59

The base branch was changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reductionista reductionista reductionista left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EasterTheBunny @reductionista @ilija42