Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ValueComparator test passing #1096

Open
wants to merge 22 commits into
base: NONEVM-1064/querykey-integration-tests
Choose a base branch
from
Open

ValueComparator test passing #1096

wants to merge 22 commits into from
+418 −74

Conversation

reductionista
Copy link
Contributor

@reductionista reductionista commented Feb 21, 2025 •
edited
Loading

These changes make the ContractReaderQueryKeysCanFilterWithValueComparator test PASS

Haven't verified that all of the tests pass yet, but so far I can confirm that this one still passes:
ContractReaderGetLatestValueGetsLatestForEvent

EasterTheBunny and others added 22 commits February 19, 2025 11:33
@EasterTheBunny
use string value for address and update writer to use chain specific …
a824851 
…name
@reductionista @EasterTheBunny
Add missing call to addReadNameForContract()
5b3f19f
@EasterTheBunny
change event sig type, assigning subkey values to idx, remove unused …
8c0e7b5 
…code
@EasterTheBunny
further bug fixes to enable event querying
00e3388
@EasterTheBunny
exclusively use big endian for big ints
e6b4993
@EasterTheBunny
first test functional
750af14
@EasterTheBunny
update chain writer to emit events for interface tests
d57bd32
@EasterTheBunny
add dep to latest common with modifier
37222a9
@EasterTheBunny
clean up existing tests
1386b72
@ilija42
Fix encode comparator item type
0c2117f
@ilija42
Revert big int encoding changes
c52a9b4
@ilija42
Enable ContractReaderQueryKeyCanFilterWithValueComparator test
3b6eaa0
@ilija42
Bump common
30904a7
@ilija42
Format CR test contract
f4f91a4
@ilija42
lint and gen CR test contract
0be9fb0
@ilija42
Fix disable tests CR comments
77708c9
@ilija42
Merge branch 'develop' into NONEVM-1064/querykey-integration-tests
382b20d
@ilija42
lint
d5462b9
@EasterTheBunny
GetLatestValue with events functional
d88aa52
@EasterTheBunny
remove address curve check and add event config
56097b7
@EasterTheBunny
update log querying for cursor values
1417f1e
@reductionista
ValueComparator test passing
9083205
@reductionista reductionista requested review from a team as code owners February 21, 2025 04:26
@cl-sonarqube-production
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 75%)

See analysis details on SonarQube

@reductionista reductionista mentioned this pull request Feb 21, 2025
Draft
@EasterTheBunny EasterTheBunny force-pushed the NONEVM-1064/querykey-integration-tests branch from a5f2ebf to e4145d3 Compare February 21, 2025 15:58
@EasterTheBunny EasterTheBunny requested a review from a team as a code owner February 21, 2025 15:58
@EasterTheBunny EasterTheBunny force-pushed the NONEVM-1064/querykey-integration-tests branch 2 times, most recently from b5e8e94 to 83cf648 Compare February 25, 2025 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@reductionista @EasterTheBunny @ilija42