Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chainreader/writer bug fixes #1088

Merged
merged 4 commits into from
Feb 19, 2025
Merged

Chainreader/writer bug fixes #1088

merged 4 commits into from
Feb 19, 2025

Conversation

EasterTheBunny
Copy link
Contributor

Description

This PR isolates bug fixes from integration test work.

@EasterTheBunny EasterTheBunny mentioned this pull request Feb 18, 2025
Draft
@EasterTheBunny EasterTheBunny force-pushed the etb/chainreader-writer-bug-fixes branch from 31d1376 to cba4da7 Compare February 19, 2025 17:33
@EasterTheBunny EasterTheBunny marked this pull request as ready for review February 19, 2025 17:34
@EasterTheBunny EasterTheBunny requested a review from a team as a code owner February 19, 2025 17:34
reductionista
reductionista previously approved these changes Feb 19, 2025
View reviewed changes
@reductionista reductionista dismissed their stale review February 19, 2025 20:09

tests failing

@EasterTheBunny EasterTheBunny force-pushed the etb/chainreader-writer-bug-fixes branch from 96bc882 to 00e3388 Compare February 19, 2025 22:03
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
80.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@chris-de-leon-cll chris-de-leon-cll merged commit 9ece21b into develop Feb 19, 2025
36 checks passed
@chris-de-leon-cll chris-de-leon-cll deleted the etb/chainreader-writer-bug-fixes branch February 19, 2025 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silaslenihan silaslenihan silaslenihan left review comments

@amit-momin amit-momin amit-momin left review comments

@ilija42 ilija42 ilija42 approved these changes

@chris-de-leon-cll chris-de-leon-cll chris-de-leon-cll approved these changes

@reductionista reductionista reductionista left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@EasterTheBunny @reductionista @silaslenihan @ilija42 @amit-momin @chris-de-leon-cll