Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group List implementation fixes #29 #30

Merged
merged 33 commits into from
Aug 28, 2024
Merged

Conversation

Vitexus
Copy link
Contributor

@Vitexus Vitexus commented Aug 12, 2024

My first try.

src/Client/Response/ListGroupResponse.php Outdated Show resolved Hide resolved
src/Api/Groups/Group.php Outdated Show resolved Hide resolved
Example/GroupsExample.php Outdated Show resolved Hide resolved
@Vitexus
Copy link
Contributor Author

Vitexus commented Aug 12, 2024

Now im working on

class ListGroupsResponseTest extends TestCase

@OskarStark
Copy link
Contributor

This PR needs a rebase please, thanks

src/Api/Groups/Group.php Outdated Show resolved Hide resolved
@Vitexus
Copy link
Contributor Author

Vitexus commented Aug 26, 2024

I think the CI works perfectly

@OskarStark
Copy link
Contributor

Can you execute make cs locally to fix CI? Thanks

@slunak
Copy link
Owner

slunak commented Aug 26, 2024

Just make sure you do it on PHP 7.4.

@Vitexus
Copy link
Contributor Author

Vitexus commented Aug 26, 2024

Can you execute make cs locally to fix CI? Thanks

image

@OskarStark
Copy link
Contributor

OskarStark commented Aug 26, 2024

Fixed in

I am using symfony binary, as it always uses the version mentioned in .php-version file, that means I can switch projects with different PHP versions and always use the desired one

https://symfony.com/download

@OskarStark
Copy link
Contributor

You should could add Fixes #29 to the PR header, so the referenced issue is closed automatically while merging this PR

@slunak
Copy link
Owner

slunak commented Aug 26, 2024

I have symfony binary installed too hence did not get the error :)

@OskarStark OskarStark mentioned this pull request Aug 28, 2024
@Vitexus
Copy link
Contributor Author

Vitexus commented Aug 28, 2024

OskarStark You want the perfect code :D

src/Client/GroupsClient.php Outdated Show resolved Hide resolved
@OskarStark
Copy link
Contributor

You want the perfect code :D

I try to be specific as possible, also final is helpful, that no-one extend code, which is not meant to be extended :-)

@slunak slunak changed the title Group List implementation #29 Group List implementation fixes #29 Aug 28, 2024
@slunak slunak merged commit bdbdd2e into slunak:master Aug 28, 2024
8 checks passed
@OskarStark
Copy link
Contributor

Thanks @Vitexus

@Vitexus Vitexus deleted the listgroups branch August 28, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants