Create group rebased #50
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Oskar Stark <[email protected]>
Phpdoc update (thanks to @OskarStark) better Example (thanks to @slunak)
OskarStark
reviewed
Aug 26, 2024
| @@ -30,6 +30,8 @@ class GroupsClient extends Client implements ClientInterface | |||
| public const ACTION_ENABLE_USER = 'enable_user'; | |||
| public const ACTION_RENAME_GROUP = 'rename'; | |||
| public const ACTION_CREATE_GROUP = 'create'; | |||
| public const ACTION_LIST_GROUPS = 'list'; | |||
OskarStark
reviewed
Aug 26, 2024
OskarStark
reviewed
Aug 26, 2024
OskarStark
reviewed
Aug 26, 2024
|
Sorry, I dont understand purpose of this PR... it is called Create Group Rebased, but includes functionality of previous PR with list groups functionality. |
|
I think we can close this PR and work in Just merge the master branch in your branch, @slunak can squash all the commits while merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.