Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/recursivetreeview issue after changing nodes #2876

Closed
wants to merge 5 commits into from
Closed

Bugfix/recursivetreeview issue after changing nodes #2876

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8cb1026
Update outdated / audited as vulnerable.
KaiStarkk Oct 14, 2024
feb0749
Add failing test for identified bug.
KaiStarkk Oct 14, 2024
61e2f6c
Add changeset
KaiStarkk Oct 14, 2024
136fa6b
Add tests to isolate the exact issue.
KaiStarkk Oct 14, 2024
4fff284
Comply with format contribution rule.
KaiStarkk Oct 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/late-months-greet.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@skeletonlabs/skeleton": patch
---

bugfix: fix RecursiveTreeView checkedNodes persistence
112 changes: 57 additions & 55 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,57 +1,59 @@
{
"name": "skeleton",
"version": "1.0.0",
"description": "monorepo for @skeletonlabs/skeleton",
"private": true,
"scripts": {
"test": "pnpm -F @skeletonlabs/skeleton test",
"preinstall": "npx only-allow pnpm",
"getall": "node scripts/checkout.cjs && pnpm i",
"postinstall": "pnpm -r sync",
"dev": "pnpm --no-sort --filter=skeleton.dev dev",
"csa": "node ./packages/create-skeleton-app/src/index.js --types=typescript --prettier --eslint --playwright=false --vitest=false --codeblocks --popups --typography --forms -t=skeleton --skeletontemplate=welcome -p=sites --monorepo --inspector",
"csl": "node ./packages/create-skeleton-app/src/index.js --types=typescript --library --prettier --eslint --playwright --vitest --codeblocks --popups --typography --forms -t=skeleton --skeletontemplate=bare -p=packages --monorepo --inspector",
"templategen": "node ./scripts/template-gen.js",
"format": "pnpm --parallel format",
"ci:publish": "changeset publish",
"ci:package": "pnpm -r package",
"ci:release": "pnpm ci:package && pnpm ci:publish",
"ci:lint": "pnpm -r lint",
"ci:check": "pnpm -r check",
"cs": "changeset"
},
"license": "MIT",
"homepage": "https://skeleton.dev/",
"repository": {
"type": "git",
"url": "https://github.com/skeletonlabs/skeleton.git"
},
"bugs": {
"url": "https://github.com/skeletonlabs/skeleton/issues"
},
"keywords": [
"cli",
"components",
"ui",
"component",
"svelte",
"component-library",
"ui-components",
"ui-framework",
"tailwind",
"tailwindcss",
"components-library",
"sveltekit"
],
"devDependencies": {
"@changesets/cli": "^2.26.1",
"@svitejs/changesets-changelog-github-compact": "^1.1.0",
"cspell": "^6.31.1",
"shelljs": "^0.8.5"
},
"engines": {
"pnpm": ">=9.2.0"
},
"packageManager": "[email protected]",
"type": "module"
"name": "skeleton",
"version": "1.0.0",
"description": "monorepo for @skeletonlabs/skeleton",
"private": true,
"scripts": {
"test": "pnpm -F @skeletonlabs/skeleton test",
"test:ui": "pnpm -F @skeletonlabs/skeleton test:ui",
"test:watch": "pnpm -F @skeletonlabs/skeleton test:watch",
"preinstall": "npx only-allow pnpm",
"getall": "node scripts/checkout.cjs && pnpm i",
"postinstall": "pnpm -r sync",
"dev": "pnpm --no-sort --filter=skeleton.dev dev",
"csa": "node ./packages/create-skeleton-app/src/index.js --types=typescript --prettier --eslint --playwright=false --vitest=false --codeblocks --popups --typography --forms -t=skeleton --skeletontemplate=welcome -p=sites --monorepo --inspector",
"csl": "node ./packages/create-skeleton-app/src/index.js --types=typescript --library --prettier --eslint --playwright --vitest --codeblocks --popups --typography --forms -t=skeleton --skeletontemplate=bare -p=packages --monorepo --inspector",
"templategen": "node ./scripts/template-gen.js",
"format": "pnpm --parallel format",
"ci:publish": "changeset publish",
"ci:package": "pnpm -r package",
"ci:release": "pnpm ci:package && pnpm ci:publish",
"ci:lint": "pnpm -r lint",
"ci:check": "pnpm -r check",
"cs": "changeset"
},
"license": "MIT",
"homepage": "https://skeleton.dev/",
"repository": {
"type": "git",
"url": "https://github.com/skeletonlabs/skeleton.git"
},
"bugs": {
"url": "https://github.com/skeletonlabs/skeleton/issues"
},
"keywords": [
"cli",
"components",
"ui",
"component",
"svelte",
"component-library",
"ui-components",
"ui-framework",
"tailwind",
"tailwindcss",
"components-library",
"sveltekit"
],
"devDependencies": {
"@changesets/cli": "^2.26.1",
"@svitejs/changesets-changelog-github-compact": "^1.1.0",
"cspell": "^6.31.1",
"shelljs": "^0.8.5"
},
"engines": {
"pnpm": ">=9.2.0"
},
"packageManager": "[email protected]",
"type": "module"
}
58 changes: 32 additions & 26 deletions packages/skeleton/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,10 @@
"check:watch": "svelte-kit sync && svelte-check --tsconfig ./tsconfig.json --watch",
"lint": "prettier --ignore-path .prettierignore --check --plugin-search-dir=. . && eslint --fix --ignore-path .gitignore .",
"format": "prettier --ignore-path .prettierignore --write --plugin-search-dir=. .",
"test": "vitest",
"test": "vitest run",
"test:ui": "vitest --ui",
"test:watch": "vitest",
"test:bench": "vitest bench",
"coverage": "vitest run --coverage",
"sync": "svelte-kit sync"
},
Expand Down Expand Up @@ -40,35 +43,38 @@
"license": "MIT",
"homepage": "https://skeleton.dev/",
"devDependencies": {
"@sveltejs/adapter-auto": "2.1.0",
"@sveltejs/kit": "1.20.5",
"@sveltejs/package": "^2.1.0",
"@testing-library/dom": "9.3.0",
"@testing-library/svelte": "4.0.1",
"@typescript-eslint/eslint-plugin": "5.59.9",
"@typescript-eslint/parser": "5.59.9",
"@vitest/coverage-c8": "0.32.0",
"autoprefixer": "10.4.14",
"eslint": "8.42.0",
"eslint-config-prettier": "8.8.0",
"eslint-plugin-svelte": "^2.31.0",
"jsdom": "21.1.1",
"postcss": "8.4.24",
"postcss-import": "15.1.0",
"@sveltejs/adapter-auto": "3.2.5",
"@sveltejs/kit": "2.7.0",
"@sveltejs/package": "^2.3.5",
"@sveltejs/vite-plugin-svelte": "^3.1.2",
"@testing-library/dom": "10.4.0",
"@testing-library/jest-dom": "^6.5.0",
"@testing-library/svelte": "5.2.3",
"@typescript-eslint/eslint-plugin": "8.8.1",
"@typescript-eslint/parser": "8.8.1",
"@vitest/ui": "^2.1.2",
"autoprefixer": "10.4.20",
"eslint": "9.12.0",
"eslint-config-prettier": "9.1.0",
"eslint-plugin-svelte": "^2.44.1",
"jsdom": "25.0.1",
"postcss": "8.4.47",
"postcss-import": "16.1.0",
"postcss-js": "4.0.1",
"postcss-load-config": "4.0.1",
"prettier": "^3.2.5",
"prettier-plugin-svelte": "^3.2.3",
"svelte": "4.2.15",
"svelte-check": "^3.4.4",
"tailwindcss": "3.3.2",
"tslib": "2.5.3",
"typescript": "5.0.3",
"vite": "4.3.9",
"vitest": "0.32.0"
"postcss-load-config": "6.0.1",
"prettier": "^3.3.3",
"prettier-plugin-svelte": "^3.2.7",
"svelte": "4.2.19",
"svelte-check": "^4.0.5",
"tailwindcss": "3.4.13",
"tslib": "2.7.0",
"typescript": "5.6.3",
"vite": "5.4.8",
"vitest": "2.1.2"
},
"type": "module",
"dependencies": {
"@vitest/coverage-v8": "^2.1.2",
"esm-env": "1.0.0"
},
"peerDependencies": {
Expand Down
Loading