-
-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/recursivetreeview issue after changing nodes #2876
Bugfix/recursivetreeview issue after changing nodes #2876
Conversation
🦋 Changeset detectedLatest commit: 4fff284 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@KaiStarkk is attempting to deploy a commit to the Skeleton Labs Team on Vercel. A member of the Team first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Just a note regarding the package upgrades, only the upgrades to testing packages were strictly necessary (vite-plugin-svelte and jest-dom) to get tests working properly, but I've aimed to resolve all updates to this point in time. |
Than you @KaiStarkk, please make sure to mark the PR "ready for review" when it reaches that state. We'll review and aim to provide feedback and/or merge asap. |
@KaiStarkk another quick reminder this is awaiting your final changes and the status being bumped up to "ready for review". Please let me know if this is continuing forward, otherwise I'll assume this is abandoned and remove. Please and thanks! |
Hi @endigo9740 , I had another look on the weekend but wasn't able to figure out the problem. Assuming the tests are still valuable, should I switch this to ready and rename it as adding the tests, rather than a fix? I will have another go at it this weekend too |
@KaiStarkk I would think if the tests are failing then this is not in a functional state. Unfortunately I am just completely absorbed in our v3 progress right now, so I can't really pause to help at the moment. But I'll bring this up with the team and see if they have any other ideas. |
These tests are still valid but anyone searching can cherry pick if needed. Closing as Svelte 5 is out now, I see that it makes much more sense to look into Skeleton 3 |
Draft
Description
This adds tests for a bug identified in #2875 . This adds 4 new tests for RecursiveTreeView which isolates the issue to one specific test, the other 3 pass.
I've submitted this PR as draft since the tests are useful, but this isn't yet a fix. Will work on it shortly.
Checklist
Please read and apply all contribution requirements.
dev
branch (NEVERmaster
)docs/
,feat/
,chore/
,bugfix/
pnpm ci:check
pnpm format
^ This caused an unrelated edit which has been added as a separate commit
pnpm test
^ There were already failing tests on dev