Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/recursivetreeview issue after changing nodes #2876

Closed

Conversation

KaiStarkk
Copy link

Draft

Description

This adds tests for a bug identified in #2875 . This adds 4 new tests for RecursiveTreeView which isolates the issue to one specific test, the other 3 pass.

I've submitted this PR as draft since the tests are useful, but this isn't yet a fix. Will work on it shortly.

Checklist

Please read and apply all contribution requirements.

  • This PR targets the dev branch (NEVER master)
  • Documentation reflects all relevant changes
  • Branch is prefixed with: docs/, feat/, chore/, bugfix/
  • Ensure Svelte and Typescript linting is current - run pnpm ci:check
  • Ensure Prettier linting is current - run pnpm format
    ^ This caused an unrelated edit which has been added as a separate commit
  • All test cases are passing - run pnpm test
    ^ There were already failing tests on dev
  • Includes a changeset (if relevant; see above)

Copy link

changeset-bot bot commented Oct 14, 2024

🦋 Changeset detected

Latest commit: 4fff284

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@skeletonlabs/skeleton Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Oct 14, 2024

@KaiStarkk is attempting to deploy a commit to the Skeleton Labs Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Oct 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
skeleton-docs ✅ Ready (Inspect) Visit Preview Oct 14, 2024 1:49pm

@KaiStarkk
Copy link
Author

Just a note regarding the package upgrades, only the upgrades to testing packages were strictly necessary (vite-plugin-svelte and jest-dom) to get tests working properly, but I've aimed to resolve all updates to this point in time.

@endigo9740
Copy link
Contributor

Than you @KaiStarkk, please make sure to mark the PR "ready for review" when it reaches that state. We'll review and aim to provide feedback and/or merge asap.

@endigo9740
Copy link
Contributor

@KaiStarkk another quick reminder this is awaiting your final changes and the status being bumped up to "ready for review". Please let me know if this is continuing forward, otherwise I'll assume this is abandoned and remove. Please and thanks!

@KaiStarkk
Copy link
Author

Hi @endigo9740 , I had another look on the weekend but wasn't able to figure out the problem. Assuming the tests are still valuable, should I switch this to ready and rename it as adding the tests, rather than a fix?

I will have another go at it this weekend too

@endigo9740
Copy link
Contributor

@KaiStarkk I would think if the tests are failing then this is not in a functional state. Unfortunately I am just completely absorbed in our v3 progress right now, so I can't really pause to help at the moment. But I'll bring this up with the team and see if they have any other ideas.

@KaiStarkk
Copy link
Author

These tests are still valid but anyone searching can cherry pick if needed. Closing as Svelte 5 is out now, I see that it makes much more sense to look into Skeleton 3

@KaiStarkk KaiStarkk closed this Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants