Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nonlinear finite-volume schemes, constant pressure aquifers, converter for CO2STORE, simplify thermal #54

Merged
merged 43 commits into from
Aug 31, 2024
Merged

Nonlinear finite-volume schemes, constant pressure aquifers, converter for CO2STORE, simplify thermal #54

merged 43 commits into from
Aug 31, 2024

Commits on Aug 6, 2024

  1. NLDD cleanup

    @moyner
    moyner committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    ff6f47f View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2024

  1. Update multiphase.jl

    @moyner
    moyner committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    8f5a63b View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2024

  1. Update CO2/brine table. Use Artifacts instead of storing files.

    @moyner
    moyner committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    daa0241 View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2024

  1. Add dispatch for thermal in discretizer

    @moyner
    moyner committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    0814886 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2024

  1. Allow passing of discretizations (WIP)

    @moyner
    moyner committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    87d26b5 View commit details
    Browse the repository at this point in the history

  2. Parse kwarg when simulator has been passed

    @moyner
    moyner committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    b0d223e View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2024

  1. Nonlinear finite-volume + AvgMPFA support (#52) 

    * Add overloads for ntpfa

* Make it easier to use non-TPFA setups

* Add kgrad to setup_reservoir_model kwarg

* Update flux_nfvm.jl

* Improvements to NFVM support

* NFVM: Clean up flux code

* Fix sign for NFVM flux with gravity

* Pass on trans to NFVM code

* Improve logic for NFVM potential

* NFVM: Correct typo

* Hacked in diffusion support for NFVM

* Ensure that NFVM potential is always non-negative

We do this by picking a new reference depth

* Update porousmedia.jl

* Put in place some preparation for fvm asm

* Update discretization settings to account for new features

* Fix general_ad branch in tpfv domain

* Hack for NLDD without TPFA hard coded (won't work for ASPEN)

* Handle new discretizations in thermal
    @moyner
    moyner authored Aug 23, 2024
    Configuration menu
    Copy the full SHA
    ed49bd2 View commit details
    Browse the repository at this point in the history

  2. Simplify thermal implementation (#53) 

    * Refactor thermal to not use composite system

* Remove export of undefined system

* Don't add rock parameters for wells

* Update thermal test

* Clean up thermal tests

* input file: Use simpler thermal system

* Thermal: Apply perforation mask to perforation flow
    @moyner
    moyner authored Aug 23, 2024
    Configuration menu
    Copy the full SHA
    3431e8b View commit details
    Browse the repository at this point in the history

  3. Thermal models should output temperature by default

    @moyner
    moyner committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    baea6a0 View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2024

  1. Fix ambiguity in convergence criterion

    @moyner
    moyner committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    bfe7600 View commit details
    Browse the repository at this point in the history

  2. Catch up to changes in thermal setup

    @moyner
    moyner committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    b468d36 View commit details
    Browse the repository at this point in the history

  3. Add overloads to make it easier to use co2brine from input file

    @moyner
    moyner committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    a450398 View commit details
    Browse the repository at this point in the history

  4. SOF2 + fixes for co2 model

    @moyner
    moyner committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    989789f View commit details
    Browse the repository at this point in the history

  5. Handle brine in initialization

    @moyner
    moyner committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    456f8a1 View commit details
    Browse the repository at this point in the history

  6. Support constant pressure/head aquifers via BC

    @moyner
    moyner committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    96285fd View commit details
    Browse the repository at this point in the history

  7. Compositional bc support + fix to aquifer

    @moyner
    moyner committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    56654c5 View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2024

  1. Add converter for CO2STORE to K-value co2brine

    @moyner
    moyner committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    ef893cc View commit details
    Browse the repository at this point in the history

  2. .DATA files: Honor all types of temperature init

    @moyner
    moyner committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    2fac7cf View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2024

  1. Updates to FVM flux interface

    @moyner
    moyner committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    2ff99bc View commit details
    Browse the repository at this point in the history

  2. Handle pc sign for co2 models

    @moyner
    moyner committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    284f2e5 View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2024

  1. Preserve original config when overwriting with additional kwargs

    @strene
    strene committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    2dcc5d5 View commit details
    Browse the repository at this point in the history

  2. Fix ambiguity in convergence_criterion signature for StandardBlackOil… 

    …System
    @strene
    strene committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    777559d View commit details
    Browse the repository at this point in the history

  3. Handle reference phase for liquid-gas initialization

    @moyner
    moyner committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    fc2def5 View commit details
    Browse the repository at this point in the history

  4. Add support for thermal BCs

    @strene
    strene committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    45a0c50 View commit details
    Browse the repository at this point in the history

  5. Remove unicode in CO2 model

    @moyner
    moyner committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    a624b54 View commit details
    Browse the repository at this point in the history

  6. Make reservoir forces into NamedTuple

    @moyner
    moyner committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    8f95778 View commit details
    Browse the repository at this point in the history

  7. Unicode removal

    @moyner
    moyner committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    47bb55d View commit details
    Browse the repository at this point in the history

  8. Revert a fix: Some ambiguities remain in two phase PC

    @moyner
    moyner committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    3813c41 View commit details
    Browse the repository at this point in the history

  9. Fix wrong head correction for constant head aquifer

    @moyner
    moyner committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    d6128dd View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2024

  1. MB for compositional

    @moyner
    moyner committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    9418c52 View commit details
    Browse the repository at this point in the history

  2. Subvariable for pt var

    @moyner
    moyner committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    cd0bfe3 View commit details
    Browse the repository at this point in the history

  3. Fix compositional version of bc

    @moyner
    moyner committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    dedd0d6 View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2024

  1. Add convenience constructors for bc

    @moyner
    moyner committed Aug 31, 2024
    Configuration menu
    Copy the full SHA
    0872e82 View commit details
    Browse the repository at this point in the history

  2. Avoid single phase densities for k value compositional

    @moyner
    moyner committed Aug 31, 2024
    Configuration menu
    Copy the full SHA
    4db27d3 View commit details
    Browse the repository at this point in the history

  3. Rewrite example

    @moyner
    moyner committed Aug 31, 2024
    Configuration menu
    Copy the full SHA
    74b8a34 View commit details
    Browse the repository at this point in the history

  4. Remove functions that are now unused

    @moyner
    moyner committed Aug 31, 2024
    Configuration menu
    Copy the full SHA
    bd343e2 View commit details
    Browse the repository at this point in the history

  5. Update co2_sloped.jl

    @moyner
    moyner committed Aug 31, 2024
    Configuration menu
    Copy the full SHA
    ee5d962 View commit details
    Browse the repository at this point in the history

  6. Rewrite example to include hysteresis

    @moyner
    moyner committed Aug 31, 2024
    Configuration menu
    Copy the full SHA
    b834359 View commit details
    Browse the repository at this point in the history

  7. Bump version

    @moyner
    moyner committed Aug 31, 2024
    Configuration menu
    Copy the full SHA
    29355d1 View commit details
    Browse the repository at this point in the history

  8. Update docs

    @moyner
    moyner committed Aug 31, 2024
    Configuration menu
    Copy the full SHA
    80de02d View commit details
    Browse the repository at this point in the history

  9. Catch up to interface changes and bump compat

    @moyner
    moyner committed Aug 31, 2024
    Configuration menu
    Copy the full SHA
    5c5194f View commit details
    Browse the repository at this point in the history

  10. Update co2_sloped.jl

    @moyner
    moyner committed Aug 31, 2024
    Configuration menu
    Copy the full SHA
    0c8eea6 View commit details
    Browse the repository at this point in the history

  11. Update make.jl

    @moyner
    moyner committed Aug 31, 2024
    Configuration menu
    Copy the full SHA
    b55d8ff View commit details
    Browse the repository at this point in the history