Nonlinear finite-volume schemes, constant pressure aquifers, converter for CO2STORE, simplify thermal #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add overloads for ntpfa * Make it easier to use non-TPFA setups * Add kgrad to setup_reservoir_model kwarg * Update flux_nfvm.jl * Improvements to NFVM support * NFVM: Clean up flux code * Fix sign for NFVM flux with gravity * Pass on trans to NFVM code * Improve logic for NFVM potential * NFVM: Correct typo * Hacked in diffusion support for NFVM * Ensure that NFVM potential is always non-negative We do this by picking a new reference depth * Update porousmedia.jl * Put in place some preparation for fvm asm * Update discretization settings to account for new features * Fix general_ad branch in tpfv domain * Hack for NLDD without TPFA hard coded (won't work for ASPEN) * Handle new discretizations in thermal
* Refactor thermal to not use composite system * Remove export of undefined system * Don't add rock parameters for wells * Update thermal test * Clean up thermal tests * input file: Use simpler thermal system * Thermal: Apply perforation mask to perforation flow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.