-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/singlestore integration tests #12
base: main
Are you sure you want to change the base?
Conversation
9ea059b
to
e79e6e9
Compare
5a8ad0e
to
fced943
Compare
integration-tests/tests/singlestore/singlestore-prefixed.test.ts
Outdated
Show resolved
Hide resolved
integration-tests/tests/singlestore/singlestore-prefixed.test.ts
Outdated
Show resolved
Hide resolved
b1b7672
to
1f47600
Compare
14712f6
to
a5f5f71
Compare
@apeng-singlestore @mitchwadair @tiagoacastro @drodrigues4 is ready to be reviewed |
Cool, I'll take a look soon 👍 |
Notable Changes
Known Issues:
|
Thank you @apeng-singlestore. I updated the PR's description with your notable changes/known issues |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally LGTM, just a few comments. Very exciting!
I also updated the main PR description with @apeng-singlestore's notes |
"name" | ||
], | ||
"isUnique": true, | ||
"using": "btree" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this should be here after removing using
method
e4c786a
to
9f50061
Compare
9f50061
to
bab7f4a
Compare
Integration Tests
Copied and renamed every mysql reference to singlestore on integration-tests directory
Key differences between MySQL vs SIngleStore IT Tests
serial
column type only assures uniqueness of the column values. The tests were modified to (set operation tests in particular) to expect SingleStore-specific behavior, by adding anORDER BY
instruction to every select instruction.ORDER BY
andLIMIT
cannot be chained together.intersectAll
andexceptAll
tests since these operations are not supported by SIngleStoreisolationLevel
config and tests as singlestore only supports oneisolationLevel
Side notes
There are some SingleStore-specific operations, such as
attach/detach
,create/drop milestone
andoptimyzeTable for column stores tables
, that are implemented ondrizzle-orm/src/singlestore-core
but not ondrizzle-kit
. There are also no integration tests for these operations. This is a known issue and should be fixed in the upcoming releases.