Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/rebase beta branch #20

Merged
merged 56 commits into from
Sep 20, 2024
Merged

Feature/rebase beta branch #20

merged 56 commits into from
Sep 20, 2024

Conversation

Rodriguespn
Copy link
Collaborator

Drizzle is planning to add SQLite Turso support in the upcoming weeks and some of the changes have conflicts with our code.

To merge into the official repository, we first need to resolve these conflicts between the main branch and the beta branch.

@Rodriguespn Rodriguespn self-assigned this Sep 18, 2024
AleksandrSherman and others added 13 commits September 18, 2024 15:13
Added:
- handling alteting columns in libsql
- new json statement for recreation table for sqlite and libsql
- push updated for sqlite and libsql
- tests
- added handling create reference and create column for sqlite and libsql
- handled alter column with unique keys
- made more tests
- updated recreate sql statements order
update migrate function in drizzle-orm
…lite to bun:sqlite; Fixed schema inferrence issue (no schema would resrresult in `unknown`, expected: `Record<string, never>`)
Copy link
Collaborator

@mitchwadair mitchwadair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like most things are dialect specific, so didn't look at those. For the common files I left some comments, mostly just adding our support to the new stuff

drizzle-orm/src/monodriver.ts Show resolved Hide resolved
drizzle-orm/src/monodriver.ts Show resolved Hide resolved
drizzle-orm/src/monomigrator.ts Outdated Show resolved Hide resolved
drizzle-orm/src/monomigrator.ts Show resolved Hide resolved
@Rodriguespn Rodriguespn force-pushed the feature/rebase-beta-branch branch 2 times, most recently from 2c57cc2 to 5da5e4c Compare September 19, 2024 11:11
@Rodriguespn
Copy link
Collaborator Author

Note: In this SingleStore driver version, the driver class nomenclature is still the old one SingleStore2Database. The integration tests PR will need rebasing after this PR is merged.

// drizzle-kit/src/api.ts
...
import { SingleStore2Database } from 'drizzle-orm/singlestore';
...

@Rodriguespn Rodriguespn merged commit 13f0835 into main Sep 20, 2024
2 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants