-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move TinyMCE code into its own module #2
Labels
Comments
2 tasks
This was referenced Feb 12, 2025
API Remove code which is being migrated to a new TinyMCE module
silverstripe/silverstripe-admin#1902
Draft
Draft
This was referenced Feb 26, 2025
Merged
This was referenced Mar 6, 2025
I'll make the requested changes once the CMS 5 PRs are merged. For now we should focus on coming to an agreement on #1 (comment) which is the only thing holding those PRs back from being merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
git TinyMCE 7 changed its license to GPLv2+, which isn't compatible with our licenses, so we need to swap to a new editor.
Regardless of whether a new editor is available in CMS 6.0.0 or in a future minor release, we want to:
Notes
Acceptance Criteria
The below all apply for CMS 6 only
silverstripe/installer
by default for CMS 6 (not recipe-cms)PRs
CMS 5
CMS 6
Important
Merge the above first and then reassign to Guy - the dist bundle in the tinymce module won't be buildable by CI until that's done
kitchen sink CI run with TinyMCE (The TinyMCE unit tests are in g2)
kitchen sink CI run with all PRs except TinyMCE (subsites and elemental behat should both fail, as they have explicit tests that can only be satisfied by tinymce right now)
Note: Upon reviewing the behat tests in elemental, it's clear they are explicitly for testing WYSIWYG functionality within elemental blocks and cannot be moved elsewhere.
Still needs to be done
phpcs.xml.dist
The text was updated successfully, but these errors were encountered: