Various changes to support TinyMCE moving #300
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
Also adds an optional param for the parent, in case you want to find a button inside a specific element.
GuySartorelli
force-pushed
the
pulls/6/no-tinymce
branch
from
d7bb7f6 to
aef2e1c
Compare
GuySartorelli
commented
Mar 6, 2025
Comment on lines
-378
to
+391
| protected function findNamedButton($title) | ||
| public function findNamedButton($title, ?ElementInterface $parent = null) | ||
| { | ||
| $page = $this->getSession()->getPage(); | ||
| if ($parent === null) { | ||
| $parent = $this->getSession()->getPage(); | ||
| } | ||
| // See https://mathiasbynens.be/notes/css-escapes | ||
| $escapedTitle = addcslashes($title ?? '', '!"#$%&\'()*+,-./:;<=>?@[\]^`{|}~'); | ||
| $matchedEl = null; | ||
| $searches = [ | ||
| ['named', ['link_or_button', "'{$title}'"]], | ||
| ['css', "button[data-text-alternate='{$escapedTitle}']"], | ||
| ]; | ||
| foreach ($searches as list($type, $arg)) { | ||
| $buttons = $page->findAll($type, $arg); | ||
| $buttons = $parent->findAll($type, $arg); |
There was a problem hiding this comment.
GuySartorelli
commented
Mar 6, 2025
Comment on lines
-992
to
+993
| var editor = jQuery('#$inputFieldId').entwine('ss').getEditor(), | ||
| doc = editor.getInstance().getDoc(), | ||
| sel = doc.getSelection(), | ||
| rng = new Range(), | ||
| matched = false; | ||
|
|
||
| jQuery(doc).find("$select").each(function() { | ||
| if(!matched) { | ||
| rng.selectNode(this); | ||
| sel.removeAllRanges(); | ||
| sel.addRange(rng); | ||
| matched = true; | ||
| } | ||
| }); | ||
| const editor = jQuery('#$inputFieldId').entwine('ss').getEditor(); | ||
| editor.selectByCssSelector("$select"); |
There was a problem hiding this comment.
The TinyMCE-specific logic here was moved into the tinymce module. The selectByCssSelector() function is in admin, and ultimately ends up calling editor-specific functionality.
GuySartorelli
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Multiple commits! Do not squash
Issue