Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT Add new context to behat config #1334

Draft
wants to merge 1 commit into
base: 6.0
Choose a base branch
from

Conversation

GuySartorelli
Copy link
Member

Copy link
Member

@emteknetnz emteknetnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will need to add a composer dev dependency for silverstripe/silverstripe-htmleditor-tinymce since there are behat tests that rely on it?

Will need a new PR for subsites to do the same?

@GuySartorelli
Copy link
Member Author

We typically accept that silverstripe/installer will be included, don't we?

@emteknetnz
Copy link
Member

emteknetnz commented Mar 11, 2025

Yeah, in practice it'll work fine in CI and on our locals, though from memory we still include dev-deps that behat needs, similar to how we do for phpunit which in practice also always has installer too

I might have remember that wrong though. It's certainly less obvious for behat when deps are actually needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants