Implement Subnet Sampling for PeerDAS #6410
Conversation
jimmygchen
added
ready-for-review
# Conflicts: # beacon_node/beacon_chain/src/data_availability_checker.rs # beacon_node/http_api/src/publish_blocks.rs # beacon_node/lighthouse_network/src/types/globals.rs # beacon_node/network/src/sync/manager.rs
Squashed commit of the following: commit 07afa6c Merge: 35f683c 50d8375 Author: Jimmy Chen <[email protected]> Date: Thu Sep 26 17:31:37 2024 +1000 Merge branch 'unstable' into subnet-sampling # Conflicts: # beacon_node/beacon_chain/src/data_availability_checker.rs # beacon_node/http_api/src/publish_blocks.rs # beacon_node/lighthouse_network/src/types/globals.rs # beacon_node/network/src/sync/manager.rs commit 35f683c Merge: 8a095f1 46e0d66 Author: Jimmy Chen <[email protected]> Date: Fri Sep 20 09:50:08 2024 +1000 Merge branch 'unstable' into subnet-sampling commit 8a095f1 Author: Jimmy Chen <[email protected]> Date: Wed Sep 18 17:07:55 2024 +1000 Update lookup test. commit ea46893 Author: Jimmy Chen <[email protected]> Date: Wed Sep 18 16:09:33 2024 +1000 Implement subnet sampling. commit 85e274f Author: Jimmy Chen <[email protected]> Date: Wed Sep 18 14:32:43 2024 +1000 Rename `sampling` module to `peer_sampling` commit 13a81e8 Author: Jimmy Chen <[email protected]> Date: Wed Sep 18 12:16:19 2024 +1000 Add `SAMPLES_PER_SLOT` config.
|
I'm missing where in the code we filter out the sampled columns and only store the custody requirement. Plus the additional sampled columns can be not random? We are always fetching the same subnets every slot and then throwing them away. |
This hasn't been implemented yet, as it requires more changes and still needs to be clarified in spec (comment earlier)
Yes that's right - this is the latest version of subnet sampling (#3870). I asked a similar question before about randomness, and Francesco doesn't think it matters for the network as a whole (see his explanation on discord here). And In the future clients can switch over to peer sampling whenever we're ready. |
jimmygchen
added
ready-for-merge
|
@mergify queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at f3a5e25 |
Issue Addressed
Addresses #6409
Proposed Changes
SAMPLES_PER_SLOT: 8config.samplingmodule topeer_sampling.Additional Info
This PR is basically a bunch of renames, because we basically treat sampling the same as custody:
With the exception that sampling subnets are not advertised in metadata and ENR. The additional sampling data may not need to be stored, however this is not currently defined in spec and will be clarified later.