Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter out the downloaded sample columns and only store the custody requirement columns #6465

Open
jimmygchen opened this issue Oct 4, 2024 · 0 comments
Labels
backlog PR is not currently prioritized das Data Availability Sampling

Comments

@jimmygchen
Copy link
Member

Description

The initial version of subnet sampling for PeerDAS was implemented in #6410, it allows for interop testing but does not filter out the sampled columns, ie. all downloaded columns, including columns for both custody and sampling are stored - however we only need to store the custody requirement columns, as peers should never query the node for columns that the node is not assigned to custody.

The change wasn't made in #6410 because it requires a bit more work, and also creates more work to switch back to Peer Sampling. However, If we do go live with Subnet Sampling, then it makes sense to exclude storing the sampling columns to save storage for non validating full nodes (a validating node will custody at least 8 columns, so it makes no difference). However given that PeerDAS has been postponed to the fork after PectraA, it probably make sense to hold off until then - as we could end up implementing Peer Sampling.

@jimmygchen jimmygchen changed the title Filter out the downloaded sample columns and only store the custody requirement Filter out the downloaded sample columns and only store the custody requirement columns Oct 4, 2024
@jimmygchen jimmygchen added the das Data Availability Sampling label Oct 4, 2024
@jimmygchen jimmygchen added the backlog PR is not currently prioritized label Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog PR is not currently prioritized das Data Availability Sampling
Projects
None yet
Development

No branches or pull requests

2 participants
@jimmygchen and others