Cleanup emitter transform from all the SDKs #853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f6243f6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
* Remove emitter transform for the Video Web API * pubSubChannel comment * test script update * remove transform pipeline for video.recording.list * emit the room.joined event through new emitter * test roomSessionStreaming with new emitter * recording list with new emitter * playback and stream list with new emitter * Update roomSessionStreaming.spec.ts * init video worker with video stream worker * video record worker init * start recording and stream function with new emitter * e2e test cases with new record and stream workers * video playback worker with new emitter * room.joined event emit through new emitter * new emitter for video manager * fix unit test case for the video manager * remove getEmitterTransform from the BaseRoomSession * remove events from the old videoAPIWorker * enable end to end test for realtime video * enable e2e for js * listen for member.talking events through new emitter * handle room.subscribed with base emitter * listen for event through new emitter is e2e realtime * consider room.left event from the new emitter * fix _off event for realtime room session * override on, once, off in base connection * override on, once, off in base connection * spawn member position worker by the video worker * temporary skip the bad network test * temporary skip the bad network test * fix roomSession playback and recording serialization * cleanup the code * fix ci cd typo * fix member position worker test * override event attach in BaseRoomSession * remove video prefix from the event * fix undefined error in mediaElementSaga * prefix video on subscription * enable roomSessionBadNetwork e2e test cases * overriden functions for room session device and screen share * changeset include * override the subscription method for video manager * fix video manager unit test * fix room session member unit test * fix TS issues * remove TODO from the subscribe worker * fix TS Call issues * add unit test for strip namespace function * use super .once for realtime room session * fix subscription bug for realtime api * fix type for events in realtime room session * fix race condition for task namespace * Remove applyEmitterTransform function from all the SDKs (#839) * Remove applyEmitterTransform function from all the SDKs * allow CI to run on the current branch * changeset include * remove branch from the CI * Remove eventsPrefix from the namespaces (#840) * Remove eventsPrefix from the namespaces * run the CI * fix base component unit test * remove event prefix from the base component * include changeset * remove branch from the CI * Shared functions enhancement (#843) * Shared functions enhancement * run the CI * rename room session stream and record instances * rename all the RT methods * include changeset * fix start recording test * remove branch from the CI * fix member list update event * Introduce the session emitter and eliminate the global emitter (#845) * Eliminate the pubSubChannel and global emitter * run the CI * introduce session emitter * fix unit tests * fix unit tests * use session events through new session emitter * emit through session emitter in pubSubSaga * fix test case for messaging client * video sdk without global emitter * ts improve * remove the old event listeners from the BaseComponent * remove find namespace from the member position worker * cleanup base component utilities * cleanup and remove the attach listeners * cleanup the old emitter usage * remove _on, _once, _off * improve ts typings * fix build issue * remove proxy utils * remove unused getCompoundEvents * include changeset * fix build issue * Cleanup the global emitter (#848) * Cleanup the global emitter * run the CI * fix build issue * fix ts issues * include changeset * Eliminate the multicast pubsub channel (#850) * emit through session emitter instead of put on pubsub channel * run the CI * remove the usage of pubsub channel * include changeset * cleanup unused actions * fix build issue * Attach listeners without the namespace prefix (#851) * fix unit tests * video sdk without global emitter * ts improve * cleanup the old emitter usage * Attach listeners without the namespace prefix * fix build issue * include changeset * stop the voicePass.test * allow voicePass.test * fallback to the prev e2e task test * emit through new emitter in task API
edolix
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR includes all the other stacked PRs Ammar created to remove the EventEmitter transform pipeline.
Type of change
Code snippets
No changes required