Cleanup emitter transform from all the SDKs (#853)

* Cleanup emitter transform from all the SDKs (#852) * Remove emitter transform for the Video Web API * pubSubChannel comment * test script update * remove transform pipeline for video.recording.list * emit the room.joined event through new emitter * test roomSessionStreaming with new emitter * recording list with new emitter * playback and stream list with new emitter * Update roomSessionStreaming.spec.ts * init video worker with video stream worker * video record worker init * start recording and stream function with new emitter * e2e test cases with new record and stream workers * video playback worker with new emitter * room.joined event emit through new emitter * new emitter for video manager * fix unit test case for the video manager * remove getEmitterTransform from the BaseRoomSession * remove events from the old videoAPIWorker * enable end to end test for realtime video * enable e2e for js * listen for member.talking events through new emitter * handle room.subscribed with base emitter * listen for event through new emitter is e2e realtime * consider room.left event from the new emitter * fix _off event for realtime room session * override on, once, off in base connection * override on, once, off in base connection * spawn member position worker by the video worker * temporary skip the bad network test * temporary skip the bad network test * fix roomSession playback and recording serialization * cleanup the code * fix ci cd typo * fix member position worker test * override event attach in BaseRoomSession * remove video prefix from the event * fix undefined error in mediaElementSaga * prefix video on subscription * enable roomSessionBadNetwork e2e test cases * overriden functions for room session device and screen share * changeset include * override the subscription method for video manager * fix video manager unit test * fix room session member unit test * fix TS issues * remove TODO from the subscribe worker * fix TS Call issues * add unit test for strip namespace function * use super .once for realtime room session * fix subscription bug for realtime api * fix type for events in realtime room session * fix race condition for task namespace * Remove applyEmitterTransform function from all the SDKs (#839) * Remove applyEmitterTransform function from all the SDKs * allow CI to run on the current branch * changeset include * remove branch from the CI * Remove eventsPrefix from the namespaces (#840) * Remove eventsPrefix from the namespaces * run the CI * fix base component unit test * remove event prefix from the base component * include changeset * remove branch from the CI * Shared functions enhancement (#843) * Shared functions enhancement * run the CI * rename room session stream and record instances * rename all the RT methods * include changeset * fix start recording test * remove branch from the CI * fix member list update event * Introduce the session emitter and eliminate the global emitter (#845) * Eliminate the pubSubChannel and global emitter * run the CI * introduce session emitter * fix unit tests * fix unit tests * use session events through new session emitter * emit through session emitter in pubSubSaga * fix test case for messaging client * video sdk without global emitter * ts improve * remove the old event listeners from the BaseComponent * remove find namespace from the member position worker * cleanup base component utilities * cleanup and remove the attach listeners * cleanup the old emitter usage * remove _on, _once, _off * improve ts typings * fix build issue * remove proxy utils * remove unused getCompoundEvents * include changeset * fix build issue * Cleanup the global emitter (#848) * Cleanup the global emitter * run the CI * fix build issue * fix ts issues * include changeset * Eliminate the multicast pubsub channel (#850) * emit through session emitter instead of put on pubsub channel * run the CI * remove the usage of pubsub channel * include changeset * cleanup unused actions * fix build issue * Attach listeners without the namespace prefix (#851) * fix unit tests * video sdk without global emitter * ts improve * cleanup the old emitter usage * Attach listeners without the namespace prefix * fix build issue * include changeset * stop the voicePass.test * allow voicePass.test * fallback to the prev e2e task test * emit through new emitter in task API * fix build issue --------- Co-authored-by: Ammar Ansari <[email protected]>
signalwire · Aug 21, 2023 · 5e1ff11 · 5e1ff11
1 parent 2567c20
commit 5e1ff11
Show file tree

Hide file tree

Showing 150 changed files with 1,912 additions and 4,323 deletions.
diff --git a/.changeset/brown-seahorses-glow.md b/.changeset/brown-seahorses-glow.md
@@ -0,0 +1,8 @@
+---
+'@signalwire/realtime-api': patch
+'@signalwire/webrtc': patch
+'@signalwire/core': patch
+'@signalwire/js': patch
+---
+
+Enhance shhared function between realtime and browser SDK
diff --git a/.changeset/dull-beers-glow.md b/.changeset/dull-beers-glow.md
@@ -0,0 +1,8 @@
+---
+'@signalwire/realtime-api': patch
+'@signalwire/webrtc': patch
+'@signalwire/core': patch
+'@signalwire/js': patch
+---
+
+Introduce the session emitter and eliminate the global emitter
diff --git a/.changeset/khaki-avocados-guess.md b/.changeset/khaki-avocados-guess.md
@@ -0,0 +1,7 @@
+---
+'@signalwire/webrtc': patch
+'@signalwire/core': patch
+'@signalwire/js': patch
+---
+
+Eliminate the multicast pubsub channel
diff --git a/.changeset/nasty-olives-press.md b/.changeset/nasty-olives-press.md
@@ -0,0 +1,7 @@
+---
+'@signalwire/realtime-api': patch
+'@signalwire/webrtc': patch
+'@signalwire/core': patch
+---
+
+Cleanup the SDK by removing eventsPrefix from the namespaces
diff --git a/.changeset/popular-doors-whisper.md b/.changeset/popular-doors-whisper.md
@@ -0,0 +1,7 @@
+---
+'@signalwire/realtime-api': patch
+'@signalwire/core': patch
+'@signalwire/js': patch
+---
+
+Attach listeners without the namespace prefix
diff --git a/.changeset/silver-needles-give.md b/.changeset/silver-needles-give.md
@@ -0,0 +1,8 @@
+---
+'@signalwire/realtime-api': patch
+'@signalwire/webrtc': patch
+'@signalwire/core': patch
+'@signalwire/js': patch
+---
+
+Cleanup the SDK by removing applyEmitterTransform
diff --git a/.changeset/tough-ads-sparkle.md b/.changeset/tough-ads-sparkle.md
@@ -0,0 +1,8 @@
+---
+'@signalwire/realtime-api': patch
+'@signalwire/webrtc': patch
+'@signalwire/core': patch
+'@signalwire/js': patch
+---
+
+Cleanup the global emitter
diff --git a/.changeset/tough-cows-reflect.md b/.changeset/tough-cows-reflect.md
@@ -0,0 +1,11 @@
+---
+'@sw-internal/e2e-realtime-api': patch
+'@signalwire/realtime-api': patch
+'@sw-internal/stack-tests': patch
+'@sw-internal/e2e-js': patch
+'@signalwire/webrtc': patch
+'@signalwire/core': patch
+'@signalwire/js': patch
+---
+
+Remove event emitter transform pipeline from browser SDK
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
@@ -4,7 +4,8 @@ on:
   push:
     branches: [main]
   pull_request:
-    branches: [main, dev]
+    branches:
+      [main, dev, aa/video-emitter-transform, aa/channels, aa/cleanup-emitter]
   workflow_dispatch:
 
 concurrency:

diff --git a/internal/e2e-js/tests/roomSession.spec.ts b/internal/e2e-js/tests/roomSession.spec.ts
@@ -685,7 +685,15 @@ test.describe('RoomSession', () => {
           const recordingEnded = new Promise((resolve) => {
             roomObj.on('recording.ended', (params) => {
               if (params.id === recording.id) {
-                resolve(params)
+                const paramWithGetters = {
+                  id: params.id,
+                  roomSessionId: params.roomSessionId,
+                  state: params.state,
+                  pause: params.pause,
+                  resume: params.resume,
+                  stop: params.stop,
+                }
+                resolve(paramWithGetters)
               }
             })
           })
@@ -722,7 +730,23 @@ test.describe('RoomSession', () => {
           const playbackEnded = new Promise((resolve) => {
             roomObj.on('playback.ended', (params) => {
               if (params.id === playback.id) {
-                resolve(params)
+                const paramWithGetters = {
+                  id: params.id,
+                  roomSessionId: params.roomSessionId,
+                  state: params.state,
+                  seekable: params.seekable,
+                  startedAt: params.startedAt,
+                  url: params.url,
+                  volume: params.volume,
+                  forward: params.forward,
+                  pause: params.pause,
+                  resume: params.resume,
+                  rewind: params.rewind,
+                  seek: params.seek,
+                  setVolume: params.setVolume,
+                  stop: params.stop,
+                }
+                resolve(paramWithGetters)
               }
             })
           })

diff --git a/internal/e2e-js/tests/roomSessionStreaming.spec.ts b/internal/e2e-js/tests/roomSessionStreaming.spec.ts
@@ -112,10 +112,21 @@ test.describe('RoomSession', () => {
               })
             )
 
+            const streamSerializer = (stream: any) => {
+              return {
+                id: stream.id,
+                roomSessionId: stream.roomSessionId,
+                state: stream.state,
+                url: stream.url,
+                stop: stream.stop,
+              }
+            }
+
             resolve({
-              streamsOnJoined: params.room_session.streams,
-              streamsOnGet: result.streams,
-              streamOnEnd,
+              streamsOnJoined:
+                params.room_session.streams?.map(streamSerializer),
+              streamsOnGet: result.streams.map(streamSerializer),
+              streamOnEnd: streamOnEnd.map(streamSerializer),
             })
           })
 
@@ -125,7 +136,7 @@ test.describe('RoomSession', () => {
 
     expect(streamsOnJoined.length).toEqual(streamsOnGet.length)
     expect(streamsOnGet.length).toEqual(streamOnEnd.length)
-    ;[streamsOnJoined, streamsOnGet, streamsOnGet].forEach((streams: any[]) => {
+    ;[streamsOnJoined, streamsOnGet, streamOnEnd].forEach((streams: any[]) => {
       streams.forEach((stream) => {
         // Since functions can't be serialized back to this
         // thread (from the previous step) we just check that

diff --git a/packages/core/src/ApplyEventListeners.ts b/packages/core/src/ApplyEventListeners.ts
diff --git a/packages/core/src/BaseClient.ts b/packages/core/src/BaseClient.ts
@@ -9,12 +9,6 @@ export class BaseClient<
 > extends BaseComponent<EventTypes> {
   constructor(public options: BaseClientOptions<EventTypes>) {
     super(options)
-    /**
-     * Since we don't need a namespace for these events
-     * we'll attach them as soon as the Client has been
-     * registered in the Redux store.
-     */
-    this._attachListeners('')
   }
 
   /**