Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dsw 1823 pr template #9

Merged
merged 6 commits into from
Mar 27, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE/docs_template.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
## Describe your changes (can list changeset entries if preferable)


## Author Checklist (complete before requesting a review)
- [ ] I have performed a self-review of my code
- [ ] If it is a core feature, I have added thorough tests
- [ ] If it is a `PIE Docs` change, I have reviewed the Docs site preview
- [ ] If it is a component change, I have reviewed the Storybook preview
- [ ] If there are visual test updates, I have reviewed them properly before approving

## Reviewer checklists (complete before approving)
### Reviewer 1
- [ ] If it is a `PIE Docs` change, I have reviewed the PR preview
- [ ] If there are visual test updates, I have reviewed them

### Reviewer 2
- [ ] If it is a `PIE Docs` change, I have reviewed the PR preview
- [ ] If there are visual test updates, I have reviewed them
17 changes: 17 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE/new_component_template.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
## Describe your changes (can list changeset entries if preferable)


## Author Checklist (complete before requesting a review)
- [ ] I have performed a self-review of my code
- [ ] I have added Playwright component tests
- [ ] I have added Playwright Viual tests and created a project in Percy
- [ ] I have reviewed the Storybook preview
- [ ] I have reviewed visual test updates properly before approving
- [ ] I have created a changeset entry.

## Reviewer checklists (complete before approving)
### Reviewer 1
- [ ] If there are visual test updates, I have reviewed them

### Reviewer 2
- [ ] If there are visual test updates, I have reviewed them
21 changes: 15 additions & 6 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -1,18 +1,27 @@
╔══════════════════════════════════════════════════════════════════════════════════════════════════╗
║ Please click the `Preview` tab and select a different PR template if your change isn't for an ║
║ existing web component. ║
║ ║
║ ║
║ [PIE Docs Template](?expand=1&template=docs_template.md) ║
║ [New Web Component Template](?expand=1&template=new_component_template.md) ║
╚══════════════════════════════════════════════════════════════════════════════════════════════════╝

## Describe your changes (can list changeset entries if preferable)


## Author Checklist (complete before requesting a review)
- [ ] I have performed a self-review of my code
- [ ] If it is a core feature, I have added thorough tests
- [ ] If it is a `PIE Docs` change, I have reviewed the Docs site preview
- [ ] If it is a component change, I have reviewed the Storybook preview
- [ ] If there are visual test updates, I have reviewed them properly before approving
- [ ] I have added Playwright component tests or ensured they exist for affected code.
- [ ] I have added Playwright Viual tests or ensured they exist for affected code.
- [ ] I have reviewed the Storybook preview
- [ ] I have reviewed visual test updates properly before approving
- [ ] If changes will affect consumers of the package, I have created a changeset entry.
- [ ] If a changeset file has been created, I have used the `/snapit` functionality to test my changes in a consuming application.

## Reviewer checklists (complete before approving)
### Reviewer 1
- [ ] If it is a `PIE Docs` change, I have reviewed the PR preview
- [ ] If there are visual test updates, I have reviewed them

### Reviewer 2
- [ ] If it is a `PIE Docs` change, I have reviewed the PR preview
- [ ] If there are visual test updates, I have reviewed them
Loading
Loading