Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dsw 1823 pr template #9

Merged
merged 6 commits into from
Mar 27, 2024
Merged

Dsw 1823 pr template #9

merged 6 commits into from
Mar 27, 2024

Conversation

siggerzz
Copy link
Owner

Describe your changes (can list changeset entries if preferable)

Author Checklist (complete before requesting a review)

  • I have performed a self-review of my code
  • If it is a core feature, I have added thorough tests
  • If it is a PIE Docs change, I have reviewed the Docs site preview
  • If it is a component change, I have reviewed the Storybook preview
  • If there are visual test updates, I have reviewed them properly before approving

Reviewer checklists (complete before approving)

Reviewer 1

  • If it is a PIE Docs change, I have reviewed the PR preview
  • If there are visual test updates, I have reviewed them

Reviewer 2

  • If it is a PIE Docs change, I have reviewed the PR preview
  • If there are visual test updates, I have reviewed them

@siggerzz siggerzz force-pushed the dsw-1823-pr-template branch from 160e9a0 to 9c2e621 Compare March 27, 2024 14:19
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Lint PR Title] ❌ Failed.
The PR title should follow the same convention used for commits, e.g.:
type(scope): DSW-123 title where DSW-123 is the Jira ticket id or DSW-000 when one is not available.

@siggerzz siggerzz merged commit eb3d037 into main Mar 27, 2024
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant