Factions Housekeeping #3815
Open
Factions Housekeeping #3815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Map Change
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
MarkSuckerberg
force-pushed
the
faction-tidy
branch
from
7fa1930 to
0785c12
Compare
github-actions
bot
added
Merge Conflict
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
MarkSuckerberg
force-pushed
the
faction-tidy
branch
from
88c2a1f to
de52db7
Compare
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 7, 2025
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> ## About The Pull Request Adds manufacturer to `ship_config_schema.json` to note the manufacturer of the ship class, which is currently displayed in the autowiki template but no information is generated. Ships missing manufacturer information: - `independent_junker.json` Assistants made this in maints with a box of scraps - `solgov_inkwell.json` SolGov Lorema has no manufacturer lore - `solgov_paracelsus.json` - `srm_elder.json` They probably just built it themselves? - `syndicate_panacea.json` Who knows, it's purple The two other ungenerated fields for faction name and header color are added in #3815.  (Example with the Atoll-Class) <!-- Describe The Pull Request. Please be sure every change is documented or this can delay review and even discourage maintainers from merging your PR! --> ## Why It's Good For The Game Fills in a field on ship wikis that previously did not have information from the game. Mostly useful for mapping or lore reference, but still helpful. <!-- Please add a short description of why you think these changes would benefit the game. If you can't justify it in words, it might not be worth adding. --> ## Changelog :cl: add: Wiki ship templates now show ship manufacturers /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. -->
MrCat15352
pushed a commit
to MrCat15352/MrCat
that referenced
this pull request
Jan 8, 2025
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> ## About The Pull Request Adds manufacturer to `ship_config_schema.json` to note the manufacturer of the ship class, which is currently displayed in the autowiki template but no information is generated. Ships missing manufacturer information: - `independent_junker.json` Assistants made this in maints with a box of scraps - `solgov_inkwell.json` SolGov Lorema has no manufacturer lore - `solgov_paracelsus.json` - `srm_elder.json` They probably just built it themselves? - `syndicate_panacea.json` Who knows, it's purple The two other ungenerated fields for faction name and header color are added in shiptest-ss13#3815.  (Example with the Atoll-Class) <!-- Describe The Pull Request. Please be sure every change is documented or this can delay review and even discourage maintainers from merging your PR! --> ## Why It's Good For The Game Fills in a field on ship wikis that previously did not have information from the game. Mostly useful for mapping or lore reference, but still helpful. <!-- Please add a short description of why you think these changes would benefit the game. If you can't justify it in words, it might not be worth adding. --> ## Changelog :cl: add: Wiki ship templates now show ship manufacturers /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. -->
|
This PR has been inactive for a month. This means it is at risk of being auto closed in a week, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
Imaginos16
added
Stale Exempt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Tidies up a little bit of our faction implementation, removing some unnecessary vars and simplifying others, and finally makes ship prefixes immutable, as well as checks if ships have the proper prefix for their faction. Also adds a lint for SolGov/Con capitalization, and adds a ton more information to the autowiki ship boxes for use.
Why It's Good For The Game
Stops people from changing ships to be factions they aren't without admin intervention.
Changelog
🆑
add: Autowiki ship table
tweak: Ship Prefixes are now immutable.
tweak: Crew manifest is prettier. In my opinion.
/:cl: