Adds manufacturer field to ship config and Autowiki #3930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Map Change
Erikafox
reviewed
Dec 22, 2024
Sadhorizon
reviewed
Dec 24, 2024
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
…to autowiki-details
shiptest-server
pushed a commit
that referenced
this pull request
Jan 7, 2025
MrCat15352
pushed a commit
to MrCat15352/MrCat
that referenced
this pull request
Jan 8, 2025
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> ## About The Pull Request Adds manufacturer to `ship_config_schema.json` to note the manufacturer of the ship class, which is currently displayed in the autowiki template but no information is generated. Ships missing manufacturer information: - `independent_junker.json` Assistants made this in maints with a box of scraps - `solgov_inkwell.json` SolGov Lorema has no manufacturer lore - `solgov_paracelsus.json` - `srm_elder.json` They probably just built it themselves? - `syndicate_panacea.json` Who knows, it's purple The two other ungenerated fields for faction name and header color are added in shiptest-ss13#3815.  (Example with the Atoll-Class) <!-- Describe The Pull Request. Please be sure every change is documented or this can delay review and even discourage maintainers from merging your PR! --> ## Why It's Good For The Game Fills in a field on ship wikis that previously did not have information from the game. Mostly useful for mapping or lore reference, but still helpful. <!-- Please add a short description of why you think these changes would benefit the game. If you can't justify it in words, it might not be worth adding. --> ## Changelog :cl: add: Wiki ship templates now show ship manufacturers /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Adds manufacturer to
ship_config_schema.jsonto note the manufacturer of the ship class, which is currently displayed in the autowiki template but no information is generated.Ships missing manufacturer information:
independent_junker.jsonAssistants made this in maints with a box of scrapssolgov_inkwell.jsonSolGov Lorema has no manufacturer loresolgov_paracelsus.jsonsrm_elder.jsonThey probably just built it themselves?syndicate_panacea.jsonWho knows, it's purpleThe two other ungenerated fields for faction name and header color are added in #3815.
(Example with the Atoll-Class)
Why It's Good For The Game
Fills in a field on ship wikis that previously did not have information from the game. Mostly useful for mapping or lore reference, but still helpful.
Changelog
🆑
add: Wiki ship templates now show ship manufacturers
/:cl: