Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement Ethereum, Polygon and Bitcoin with phantom #677
feat: implement Ethereum, Polygon and Bitcoin with phantom #677
Changes from 4 commits
507e342
f516a17
617ea6c
07b2584
014913d
50f63cf
69d8892
b55e957
d622b47
af83e76
0ff0419
14fa180
bde4f7a
65c70ff
2e6c32c
9357bdc
29f33c8
23fa837
a5b9296
e5b646a
2d1645d
76a77d6
a80e1e1
e863308
d14e519
d227432
2094a1f
df0d141
860373c
f620a16
6193e58
b82d050
d6e3e96
128b407
e810ac0
de602be
53a5cd0
8aee937
5637977
a9d3035
389d7e6
8e1fff9
a5078c5
248372b
e149db1
f528f10
66b2348
0f648fd
0ff50a4
dd5b0f1
6b89f94
7cb54cb
1107098
e18b090
1e04575
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note:
checkIsMetaMaskImpersonator
will fail in web, which we may or may not have to accommodate: https://github.com/MetaMask/detect-provider/blob/4b85b3445c746b40d4a52a5679dfe357f29238c4/src/detect-ethereum-provider.ts#L31 (notably,handleSend
anduseStakingAction
use it for MM with snaps detection