feat: implement Ethereum, Polygon and Bitcoin with phantom #677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
NeOMakinG
commented
Sep 9, 2024
NeOMakinG
commented
Sep 9, 2024
NeOMakinG
commented
Sep 9, 2024
NeOMakinG
commented
Sep 9, 2024
NeOMakinG
changed the title
| } | ||
|
|
||
| public async pairDevice(): Promise<PhantomHDWallet | undefined> { | ||
| const evmProvider = window.phantom?.ethereum; |
There was a problem hiding this comment.
Note: checkIsMetaMaskImpersonator will fail in web, which we may or may not have to accommodate: https://github.com/MetaMask/detect-provider/blob/4b85b3445c746b40d4a52a5679dfe357f29238c4/src/detect-ethereum-provider.ts#L31 (notably, handleSend and useStakingAction use it for MM with snaps detection
kaladinlight
previously approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
gomes notes:
Two spotted issues with Phantom:
window.ethereum.request()calls in console https://github.com/orgs/phantom/discussions/294neo notes:
First of all, I was thinking that the concept was pretty similar to metamask with snap at some point, so I started from this package.
The EVM part is following the EIP-1193 standard as stated in https://docs.phantom.app/ethereum-and-polygon/getting-started , so the implementation is very similar to any wallets as MetaMask.
Providers
Phantom as multiple providers, this is kinda why I had to store them all in memory, to communicate with the bitcoin part, we need to use the bitcoin provider. We only have a single provider for every EVM supporteds.
BTC TX
Phantom require to build the TX using PSBT, the logic is kinda like Native