Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ManagerTask type for synaptor dags #90

Merged
merged 2 commits into from
Apr 28, 2024
Merged

ManagerTask type for synaptor dags #90

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
394a863
Add a ManagerTask type
ranlu Apr 28, 2024
d7e1c79
Do not switch clusters for manager type
ranlu Apr 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions dags/synaptor_dags.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,14 @@ def __init__(self, name):
self.use_gpus = False


class ManagerTask(Task):

def __init__(self, name):
self.name = name
self.cluster_key = "manager"
self.use_gpus = False


def fill_dag(dag: DAG, tasklist: list[Task], collect_metrics: bool = True) -> DAG:
"""Fills a synaptor DAG from a list of Tasks."""
drain = drain_op(dag)
Expand Down Expand Up @@ -126,7 +134,7 @@ def fill_dag(dag: DAG, tasklist: list[Task], collect_metrics: bool = True) -> DA
def change_cluster_if_required(
dag: DAG, prev_cluster_tag: str, curr_operator: BaseOperator, next_task: Task,
) -> tuple[str, BaseOperator]:
if next_task.cluster_key in prev_cluster_tag:
if next_task.cluster_key == "manager" or next_task.cluster_key in prev_cluster_tag:
# don't need to change the cluster
return prev_cluster_tag, curr_operator

Expand Down Expand Up @@ -220,6 +228,8 @@ def add_task(
if task.name == "self_destruct":
cluster_key = cluster_key_from_tag(tag)
generate = self_destruct_op(dag, queue=cluster_key, tag=tag)
elif task.cluster_key == "manager":
generate = manager_op(dag, task.name, image=SYNAPTOR_IMAGE)
else:
generate = generate_op(dag, task.name, image=SYNAPTOR_IMAGE, tag=tag)

Expand Down Expand Up @@ -262,8 +272,10 @@ def add_task(
CPUTask("chunk_ccs"),
CPUTask("match_contins"),
GraphTask("seg_graph_ccs"),
CPUTask("chunk_seg_map"),
ManagerTask("index_seg_map"),
ManagerTask("chunk_seg_map"),
CPUTask("merge_seginfo"),
ManagerTask("index_chunked_seg_map"),
GPUTask("chunk_edges"),
CPUTask("pick_edge"),
CPUTask("merge_dups"),
Expand Down
Loading