-
Notifications
You must be signed in to change notification settings - Fork 20
This modifies the WPT page to show information about subtests #233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Preview link: https://servo.org/wpt-subtests/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on the screenshot, the table looks more noisy to me than before. While part of the reason might be the font that we are using (the font we used before the UI moved to servo.org was more fixed-width and scores had 3 digits, so the numbers across rows were aligned vertically).
While I admit it might be hard to make drastic improvements here as we have very large numbers with variable number digits, I wonder if we can make some simple changes like making the column to be left-aligned or switching to a more readable font for the table.
This doesn't have to block this PR though.
Preview link: https://servo.org/wpt-subtests/ |
3 similar comments
Preview link: https://servo.org/wpt-subtests/ |
Preview link: https://servo.org/wpt-subtests/ |
Preview link: https://servo.org/wpt-subtests/ |
Preview link: https://servo.org/wpt-subtests/ |
If we want to land this without breakage, I can import temporarily the json files into the website, so this will work for those results. And then land the other patch and when things are updated on wpt.servo.org/*.json remove the local files and start using the remote ones again. Not sure if this is really needed, but I can do that if you think it's relevant. |
This looks so much better! Thanks!
I'm not too worried by the temporary breakage. We can merge the other patch first so that the github action will run and recalculate all scores, producing the new scores.json format and then merge this one so the UI updates only after the JSON is generated. |
Preview link: https://servo.org/wpt-subtests/ |
I've made an extra change that uses |
This is a companion of servo/internal-wpt-dashboard#56 Co-authored-by: Mukilan Thiyagarajan <[email protected]> Signed-off-by: Manuel Rego Casasnovas <[email protected]>
Preview link: https://servo.org/wpt-subtests/ |
I've fixed the rendering on the table on mobile by adding a containter that allows horizontal scroll (like we have for the table in sponsoring). I think this is ready to land. After we land servo/internal-wpt-dashboard#56 and we generate the new json files. |
This is a companion of servo/internal-wpt-dashboard#56